From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gettext-tiny: fix build of libintl.a
Date: Sun, 31 Mar 2019 20:56:36 +0200 [thread overview]
Message-ID: <20190331205636.1c64360a@windsurf> (raw)
In-Reply-To: <20190331153429.7380-1-yann.morin.1998@free.fr>
On Sun, 31 Mar 2019 17:34:29 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Since libintl.a can be pulled in during the build of other shared libs,
> it must be compiled with -fPIC, which is what gettext-tiny's Makefile
> would do.
>
> Since we provide our own CFLAGS, they override those in the Makefile.
>
> Fix that by ensurign that -fPIC is used when building the static
> library.
>
> Fixes:
> http://autobuild.buildroot.org/results/a38/a3800fd4ef2536cc2b82d38ea752baa2b227bc64/
>
> Also, since GETTEXT_TINY_OPTS is used only once and contains a single
> definition, get rid of it altogether.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Vadim Kochan <vadim4j@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/gettext-tiny/gettext-tiny.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-03-31 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 15:34 [Buildroot] [PATCH] package/gettext-tiny: fix build of libintl.a Yann E. MORIN
2019-03-31 18:56 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190331205636.1c64360a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox