From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/vim: fix build for the host if NLS is disabled
Date: Mon, 1 Apr 2019 21:46:26 +0200 [thread overview]
Message-ID: <20190401214626.679bff62@windsurf> (raw)
In-Reply-To: <1554124857-10946-1-git-send-email-email@gmail.com>
Hello Vadim,
On Mon, 1 Apr 2019 16:20:57 +0300
Vadim Kochan <vadim4j@gmail.com> wrote:
> HOST_VIM_DEPENDENCIES = host-ncurses
> +HOST_VIM_CONF_OPTS = --with-tlib=ncurses \
> + --enable-gui=no \
> + --without-x \
> + --disable-acl \
> + --disable-gpm \
> + --disable-selinux \
> + --disable-nls
Indentation should have been just one tab. I fixed that up and applied.
However, for target packages, we are passing --enable-nls/--disable-nls
in the autotools-package infrastructure. Perhaps we should simply do
the same for host packages and always pass --disable-nls ? We have a
few host packages already passing --disable-nls:
package/acl/acl.mk:ACL_CONF_OPTS = --disable-nls
package/acl/acl.mk:HOST_ACL_CONF_OPTS = --disable-nls
package/attr/attr.mk:ATTR_CONF_OPTS = --disable-nls
package/attr/attr.mk:HOST_ATTR_CONF_OPTS = --disable-nls
package/gcc/gcc-initial/gcc-initial.mk: --disable-nls \
package/gutenprint/gutenprint.mk: --disable-nls \
package/gutenprint/gutenprint.mk: --disable-nls-macos \
package/lvm2/lvm2.mk: --disable-nls \
package/ushare/ushare.mk:USHARE_CONF_OPTS += --disable-nls
package/vim/vim.mk: --disable-nls
Since it works for target packages, I think it should be OK to do the
same for host packages, no?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-04-01 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 13:20 [Buildroot] [PATCH 1/1] package/vim: fix build for the host if NLS is disabled Vadim Kochan
2019-04-01 19:46 ` Thomas Petazzoni [this message]
2019-04-01 20:11 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401214626.679bff62@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox