From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/14] package/perl-class-inspector: bump to version 1.34
Date: Mon, 1 Apr 2019 22:12:22 +0200 [thread overview]
Message-ID: <20190401221222.19afc83e@windsurf> (raw)
In-Reply-To: <20190331174449.1461-1-francois.perrad@gadz.org>
Hello Fran?ois,
On Sun, 31 Mar 2019 19:44:36 +0200
Francois Perrad <fperrad@gmail.com> wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
I have applied your series of 14 patches, but there were a number of
issues with them, which I fixed. I'll reply to the problematic patches.
I have to say that I kind of expect a regular contributor like you to
not submit patches with such issues. The first one is in this patch.
> # computed by scancpan
> -sha256 3ed0185f73a0570b72a2dc95c6bde500dc800c6f778ccbd688df4f88e6e65232 LICENSE
> +sha256 401fe9c98bdb5707df71447fb93141f8cb2d85337d45505f5ae50a776a3f6666 LICENSE
When the license file hash changes, there must be a note in the commit
log that explains what changed. Otherwise, we can't know if the
contributor has done a proper check, or just blindly updated the hash.
The rule is clear: any change to the license files MUST be explained
in the commit log.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-04-01 20:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 17:44 [Buildroot] [PATCH 01/14] package/perl-class-inspector: bump to version 1.34 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 02/14] package/perl-data-uuid: bump to version 1.224 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 03/14] package/perl-date-manip: bump to version 6.76 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 04/14] package/perl-dbi: bump to version 1.642 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 05/14] package/perl-file-slurp: bump to version 9999.26 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 06/14] package/perl-gd: bump to version 2.71 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 07/14] package/perl-io-socket-ssl: bump to version 2.066 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 08/14] package/perl-libwww-perl: bump to version 6.38 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 09/14] package/perl-lwp-mediatypes: bump to version 6.04 Francois Perrad
2019-04-01 20:13 ` Thomas Petazzoni
2019-03-31 17:44 ` [Buildroot] [PATCH 10/14] package/perl-net-dns: bump to version 1.20 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 11/14] package/perl-net-ping: bump to version 2.72 Francois Perrad
2019-03-31 17:44 ` [Buildroot] [PATCH 12/14] package/perl-net-ssh2: bump to version 0.70 Francois Perrad
2019-04-01 20:13 ` Thomas Petazzoni
2019-03-31 17:44 ` [Buildroot] [PATCH 13/14] package/perl-sub-quote: bump to version 2.006003 Francois Perrad
2019-04-01 20:14 ` Thomas Petazzoni
2019-03-31 17:44 ` [Buildroot] [PATCH 14/14] package/perl-xml-libxml: bump to version 2.0134 Francois Perrad
2019-04-01 20:12 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401221222.19afc83e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox