Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/2] arch: add support for Andes 32-bit(nds32)
Date: Wed, 3 Apr 2019 09:31:14 +0200	[thread overview]
Message-ID: <20190403093114.6f6b3108@windsurf> (raw)
In-Reply-To: <20190402072340.17989-2-nylon7@andestech.com>

Hello Nylon,

Thanks for this contribution!

On Tue, 2 Apr 2019 15:23:39 +0800
Nylon Chen <nylon7@andestech.com> wrote:

> This commit provides basic support for the Andes 32-bit(nds32) architecture.
> 
> Signed-off-by: Che-Wei Chuang <cnoize@andestech.com>
> Signed-off-by: Greentime Hu <greentime@andestech.com>
> Signed-off-by: Nylon Chen <nylon7@andestech.com>

If we are adding a new architecture, we will need to test it in our
autobuilders (http://autobuild.buildroot.org). Are you ready to spend
some time to look at the build failures, and fix the ones that are
related to the nds32 architecture ?

To make such testing happen, we will need to add a toolchain
configuration in support/config-fragments/autobuild/, and add it in
support/config-fragments/autobuild/toolchain-configs.csv.

This toolchain configuration can directly point to the pre-built
toolchain you are using in PATCH 2/2.

Or, perhaps better, this pre-built toolchain can be added as a proper
package in toolchain/toolchain-external/, and then both the defconfig
and the autobuilder configuration can use it.

What do you think ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-04-03  7:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02  7:23 [Buildroot] [PATCH v4 0/2] Add prebuilt nds32 toolchain, ae3xx board Nylon Chen
2019-04-02  7:23 ` [Buildroot] [PATCH v4 1/2] arch: add support for Andes 32-bit(nds32) Nylon Chen
2019-04-02 19:52   ` Yann E. MORIN
2019-04-03  7:31   ` Thomas Petazzoni [this message]
2019-04-09  9:26     ` Nylon Chen
2019-04-09  9:36       ` Thomas Petazzoni
2019-04-02  7:23 ` [Buildroot] [PATCH v4 2/2] configs/andes_nds32_ae3xx: new defconfig Nylon Chen
2019-04-02 20:00   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403093114.6f6b3108@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox