From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/uboot-tools: fix CONFIG_FIT_SIGNATURE_MAX_SIZE build failure
Date: Wed, 3 Apr 2019 22:32:35 +0200 [thread overview]
Message-ID: <20190403223235.7d04da12@windsurf> (raw)
In-Reply-To: <20190331202029.97561-1-giulio.benetti@micronovasrl.com>
Hello,
On Sun, 31 Mar 2019 22:20:29 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> When CONFIG_FIT_SIGNATURE is enabled for building,
> CONFIG_FIT_SIGNATURE_MAX_SIZE must be defined since it's a dependency of
> CONFIG_FIT_SIGNATURE. Using uboot Kconfig, CONFIG_GIT_SIGNATURE_MAX_SIZE
> is set to its default(0x10000000) according to Kconfig, but Buildroot
> doesn't use uboot Kconfig, it passes directly CONFIG_* as make
> arguments.
>
> Append CONFIG_FIT_SIGNATURE_MAX_SIZE=0x10000000 after
> CONFIG_FIT_SIGNATURE=y to UBOOT_TOOLS_MAKE_OPTS and
> HOST_UBOOT_TOOLS_MAKE_OPTS.
>
> Fixes:
> http://autobuild.buildroot.net/results/612/6126848e08d9273911e7d5b0151847aa2293ed87/
> http://autobuild.buildroot.net/results/b49/b49ae4977b605ed24783161618f383551f1662b8/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> package/uboot-tools/uboot-tools.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks. Long term I think we should try to use the
Kconfig stuff even for uboot-tools, but for a short term solution, your
patch is fine.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-04-03 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 20:20 [Buildroot] [PATCH] package/uboot-tools: fix CONFIG_FIT_SIGNATURE_MAX_SIZE build failure Giulio Benetti
2019-04-03 20:32 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403223235.7d04da12@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox