From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 8 Apr 2019 09:18:20 +0200 Subject: [Buildroot] [PATCH] package/android-tools: fix static build failure due to missing -latomic In-Reply-To: References: <20190404153904.69693-1-giulio.benetti@micronovasrl.com> <20190404224539.2d79cf30@windsurf> <699842f1-d9e3-dd02-4770-e8a10499194b@micronovasrl.com> Message-ID: <20190408091820.2a7274a1@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Giulio, On Sun, 7 Apr 2019 23:55:38 +0200 Giulio Benetti wrote: > >> -LIBS+= -lc -lpthread -lz -lcrypto -lcrypt `pkg-config --libs glib-2.0 gio-2.0` > > In current version there is not glib-2.0 or gio-2.0, do I add them > anyway as follows? Wow, I got confused about this. pkg-config is used for glib-2.0 and gio-2.0 in the upstream android-tools code, but we remove that in our 0002-Fix-adbd-for-non-Ubuntu-systems.patch patch. So of course, don't re-add those pkg-config calls for glib-2.0 and gio-2.0. However, use pkg-config for OpenSSL. This will also allow you to drop patch 0005-fix-static-link-zlib.patch, which was needed for the same reason: pkg-config is not used to find OpenSSL. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com