From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] linux: use host pkg-config when host libelf is set
Date: Mon, 8 Apr 2019 22:01:00 +0200 [thread overview]
Message-ID: <20190408200100.GC23890@scaer> (raw)
In-Reply-To: <899a55d6cfd3f183da8053082c645342242c9bdd.camel@intel.com>
Stuart, All,
On 2019-04-08 19:41 +0000, Summers, Stuart spake thusly:
> On Mon, 2019-04-08 at 21:28 +0200, Yann E. MORIN wrote:
[--SNIP--]
> > > $(2)_CONFIGURATOR_MAKE_ENV = \
> > > - $$(filter-out PATH=% PKG_CONFIG=% PKG_CONFIG_SYSROOT_DIR=%
> > > PKG_CONFIG_LIBDIR=%,$$($(2)_MAKE_ENV)) \
> > > + $$(filter-out PATH=% PKG_CONFIG=% PKG_CONFIG_SYSROOT_DIR=% \
> > > + PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=%
> > > PKG_CONFIG_ALLOW_SYSTEM_LIBS=% \
> > > + PKG_CONFIG_LIBDIR=%,$$($(2)_MAKE_ENV)) \
> >
> > I'm not too happy abfor the poout the look the above has, but I have
> > no better
> > formatting suggestion to provide...
> Yeah, I agree it looks ugly.. If you have suggestions, I'm happy to
> take a look.
No, I ahve no better suggestion, really, hence I gave my:
> > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Thanks for the review and the time here!
>
> Given this is my first patch, I'm not sure I have push rights. Can you
> help with merging? Also, would you like a re-post with the commit
> message recommendations above?
When one of the three maintainer have time, they'll pick up that patch
and apply; it's not going to be forgotten: all patches are tracked on
patchwork:
https://patchwork.ozlabs.org/project/buildroot/list/
The committer can probably apply the tweaks I suggested when they apply,
so no need to respin unless requested, now.
Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-04-08 20:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 19:24 [Buildroot] [PATCH 0/1] [RFC] fix kernel build failure for 5.1.0-rc3 Stuart Summers
2019-04-04 19:24 ` [Buildroot] [PATCH 1/1] package/pkgconf: add host link to pkg-config Stuart Summers
2019-04-04 19:42 ` Thomas Petazzoni
2019-04-04 21:30 ` Summers, Stuart
2019-04-05 7:53 ` Thomas Petazzoni
2019-04-05 18:50 ` Summers, Stuart
2019-04-05 18:47 ` [Buildroot] [PATCH] linux: use host pkg-config when host libelf is set Stuart Summers
2019-04-06 20:31 ` Yann E. MORIN
2019-04-08 16:00 ` Summers, Stuart
2019-04-08 16:36 ` Yann E. MORIN
2019-04-08 18:42 ` [Buildroot] [PATCH 1/1] " Stuart Summers
2019-04-08 19:28 ` Yann E. MORIN
2019-04-08 19:41 ` Summers, Stuart
2019-04-08 20:01 ` Yann E. MORIN [this message]
2019-04-13 15:09 ` Arnout Vandecappelle
2019-04-15 14:29 ` Summers, Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408200100.GC23890@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox