From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 04/12 v2] infra/pkg-download: make the DOWNLOAD macro fully parameterised
Date: Mon, 15 Apr 2019 19:18:10 +0200 [thread overview]
Message-ID: <20190415171810.GS2539@scaer> (raw)
In-Reply-To: <bc74daf9-0a18-48aa-d60e-16f1371c7451@mind.be>
Arnout, All,
On 2019-04-15 11:08 +0200, Arnout Vandecappelle spake thusly:
> On 14/04/2019 22:17, Yann E. MORIN wrote:
> > diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> > index a83813e28d..f78ff2e665 100644
> > --- a/package/pkg-generic.mk
> > +++ b/package/pkg-generic.mk
> > @@ -149,7 +149,7 @@ $(BUILD_DIR)/%/.stamp_downloaded:
> > break ; \
> > fi ; \
> > done
> > - $(foreach p,$($(PKG)_ALL_DOWNLOADS),$(call DOWNLOAD,$(p))$(sep))
> > + $(foreach p,$($(PKG)_ALL_DOWNLOADS),$(call DOWNLOAD,$(p),$(PKG))$(sep))
> > $(foreach hook,$($(PKG)_POST_DOWNLOAD_HOOKS),$(call $(hook))$(sep))
> > $(Q)mkdir -p $(@D)
> > @$(call step_end,download)
>
> Maybe this is the thing you forgot to amend, but: the DOWNLOAD macro is also
> used a couple of lines lower for the actual_source.
Good catch. And no, that was not the thing I missed...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-04-15 17:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 20:17 [Buildroot] [PATCH 00/12 v2] infra: add solution to dump metadata from packages (branch yem/show-info-2) Yann E. MORIN
2019-04-14 20:17 ` [Buildroot] [PATCH 01/12 v2] infra/pkg-download: return just a list of URIs Yann E. MORIN
2019-04-14 20:17 ` [Buildroot] [PATCH 02/12 v2] infra/pkg-download: make the URI list a callable macro Yann E. MORIN
2019-04-14 20:17 ` [Buildroot] [PATCH 03/12 v2] infra/pkg-download: get rid of the FLOCK variable Yann E. MORIN
2019-04-14 20:17 ` [Buildroot] [PATCH 04/12 v2] infra/pkg-download: make the DOWNLOAD macro fully parameterised Yann E. MORIN
2019-04-15 9:08 ` Arnout Vandecappelle
2019-04-15 17:18 ` Yann E. MORIN [this message]
2019-04-14 20:17 ` [Buildroot] [PATCH 05/12 v2] infra/utils: add helper to generate comma-separated lists Yann E. MORIN
2019-04-14 20:17 ` [Buildroot] [PATCH 06/12 v2] fs: introduce variables with name and type Yann E. MORIN
2019-04-14 20:17 ` [Buildroot] [PATCH 07/12 v2] fs: introduce variable with all recursive dependencies Yann E. MORIN
2019-04-14 20:17 ` [Buildroot] [PATCH 08/12 v2] fs: add all recursive dependencies to packages list Yann E. MORIN
2019-04-15 9:48 ` Arnout Vandecappelle
2019-04-14 20:17 ` [Buildroot] [PATCH 09/12 v2] core: introduce new global show-info Yann E. MORIN
2019-04-15 12:17 ` Arnout Vandecappelle
2019-04-15 12:23 ` Thomas Petazzoni
2019-04-15 17:34 ` Yann E. MORIN
2019-04-15 17:51 ` Arnout Vandecappelle
2019-04-15 18:51 ` Yann E. MORIN
2019-04-16 9:47 ` Peter Korsgaard
2019-04-16 19:49 ` Arnout Vandecappelle
2019-04-16 20:10 ` Peter Korsgaard
2019-04-14 20:17 ` [Buildroot] [PATCH 10/12 v2] core: add per-package and per-filesystem show-info Yann E. MORIN
2019-04-14 20:17 ` [Buildroot] [PATCH 11/12 v2] support/scripts: use show-info to extract dependency graph Yann E. MORIN
2019-04-14 20:17 ` [Buildroot] [PATCH 12/12 v2] core: remove show-depednency-tree Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415171810.GS2539@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox