Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/mpd: bump to version 0.21.7
Date: Mon, 15 Apr 2019 22:42:45 +0200	[thread overview]
Message-ID: <20190415224245.787eee35@windsurf> (raw)
In-Reply-To: <20190415203618.7598-1-joerg.krause@embedded.rocks>

Hello J?rg,

On Mon, 15 Apr 2019 22:36:18 +0200
J?rg Krause <joerg.krause@embedded.rocks> wrote:

> The Meson build system detects the `libgcrypt-config` program by looking for the
> corresponding entry in the cross file and falls back to searching PATH. As we
> do not want creeping libgcrypt-config into the global cross-file and the
> current Meson version 0.49 does not offer us any other way to pass the
> libgcrypt-config entry to the configuration step, we are forced to pass it
> through PATH.
> 
> To prevent detecting the hosts libgcrypt-config program, we force detecting
> the program installed in staging by passing the staging dir early in PATH.

Except it is not a wise idea at all to add $(STAGING_DIR)/usr/bin to
PATH, because $(STAGING_DIR)/usr/bin contains binaries compiled for the
target. For example, if Python has been built, then "python" will be in
$(STAGING_DIR)/usr/bin, and because you put $(STAGING_DIR)/usr/bin in
front of everything else, the target-built python will be used during
the build process. Not good.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-04-15 20:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 20:36 [Buildroot] [PATCH v2] package/mpd: bump to version 0.21.7 Jörg Krause
2019-04-15 20:42 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190415224245.787eee35@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox