From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] package/ngircd: fix static build with openssl and atomic
Date: Mon, 15 Apr 2019 23:14:16 +0200 [thread overview]
Message-ID: <20190415231416.050afc4d@windsurf> (raw)
In-Reply-To: <25c2ed7a-d9b3-8066-6cfc-e26c84713dec@mind.be>
On Mon, 15 Apr 2019 23:08:00 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> > package/ngircd/ngircd.mk:23: use $() to delimit variables, not ${}
> > package/ngircd/ngircd.mk:26: use $() to delimit variables, not ${}
>
> Huh? How could this ever have worked? make will replace the ${SERIAL_TESTS}
> with the empty string, since the SERIAL_TESTS variable is not defined. Fabrice,
> did you actually test this? Or maybe the SERIAL_TESTS is empty anyway?
SERIAL_TESTS would be "serial-tests" in our case:
https://github.com/ngircd/ngircd/blob/master/autogen.sh#L190
https://www.gnu.org/software/automake/manual/html_node/Serial-Test-Harness.html
I guess it's only used when you run "make check", so we don't really
care in the context of Buildroot.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-04-15 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 15:51 [Buildroot] [PATCH v2, 1/1] package/ngircd: fix static build with openssl and atomic Fabrice Fontaine
2019-04-15 20:10 ` Thomas Petazzoni
2019-04-15 21:08 ` Arnout Vandecappelle
2019-04-15 21:14 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415231416.050afc4d@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox