Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification
Date: Mon, 22 Apr 2019 22:34:41 +0200	[thread overview]
Message-ID: <20190422203441.GC6200@scaer> (raw)
In-Reply-To: <20190422200830.2831-1-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:
>  - Due to calling "make all", a little bit more might get built, and
>    sometimes this "little bit more" needs mkimage, so we add
>    host-uboot-tools to the defconfig. This is enough as linux/linux.mk
>    automatically adds host-uboot-tools to its dependency if it's
>    enabled. I hesitated with adding an explicit
>    BR2_LINUX_KERNEL_NEEDS_HOST_UBOOT_TOOLS option, let me know if this
>    sounds better or if the proposed solution in this patch series is
>    good enough.

Ithink the NEEDS_FOO options are only interesting when the host package
does not have a kconfig option of its own.

In this case, I think it is correct to do as you did.

If linux did not have a conditional dependency on host-uboot-tools, then
it should be added, rather than add a NEEDS_HOST_UBOOT_TOOLS.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2019-04-22 20:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 20:08 [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Thomas Petazzoni
2019-04-22 20:08 ` [Buildroot] [PATCH 1/5] linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets Thomas Petazzoni
2019-04-22 20:30   ` Yann E. MORIN
2019-04-26 13:01   ` Peter Korsgaard
2019-04-22 20:08 ` [Buildroot] [PATCH 2/5] configs/beaglebone: kernel build needs mkimage Thomas Petazzoni
2019-04-22 20:35   ` Yann E. MORIN
2019-04-26 13:02   ` Peter Korsgaard
2019-04-22 20:08 ` [Buildroot] [PATCH 3/5] configs/qemu_nios2_10m50: " Thomas Petazzoni
2019-04-22 20:36   ` Yann E. MORIN
2019-04-26 13:02   ` Peter Korsgaard
2019-04-22 20:08 ` [Buildroot] [PATCH 4/5] configs/qemu_ppc_mpc8544ds: " Thomas Petazzoni
2019-04-22 20:36   ` Yann E. MORIN
2019-04-26 13:02   ` Peter Korsgaard
2019-04-22 20:08 ` [Buildroot] [PATCH 5/5] configs/qemu_ppc_virtex_ml507: " Thomas Petazzoni
2019-04-22 20:37   ` Yann E. MORIN
2019-04-26 13:02   ` Peter Korsgaard
2019-04-22 20:34 ` Yann E. MORIN [this message]
2019-04-24 20:47 ` [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190422203441.GC6200@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox