From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5base: fix qmake parallel build
Date: Mon, 22 Apr 2019 22:25:28 +0200 [thread overview]
Message-ID: <20190422222528.492c48ca@windsurf> (raw)
In-Reply-To: <20190422095842.61772-1-giulio.benetti@micronovasrl.com>
On Mon, 22 Apr 2019 11:58:42 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> When configuring qt5base, qmake is built, but it's not built in parallel
> mode. This is due to MAKEFLAGS having 2 dashes on its tail, so this:
> MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)"
> expands in this(i.e. 5 njobs):
> MAKEFLAGS="--no-print-directory -- -j5"
> and -j5 gets ignored due to "--" preceeding -j5.
> Double dashes are part of $(MAKEFLAGS) only when evaluated by shell.
>
> Swap $(MAKEFLAGS) and -j$(PARALLEL_JOBS) to avoid having "--" before
> -j$(PARALLEL_JOBS), this way -j$(PARALLEL_JOBS) won't be ignored by
> ./configure.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> package/qt5/qt5base/qt5base.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-04-22 20:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 22:16 [Buildroot] Qt5 parallel build of qmake Arnout Vandecappelle
2019-04-17 22:53 ` Giulio Benetti
2019-04-21 7:08 ` Arnout Vandecappelle
2019-04-21 22:43 ` Giulio Benetti
2019-04-22 7:56 ` Arnout Vandecappelle
2019-04-22 9:46 ` Giulio Benetti
2019-04-22 9:58 ` [Buildroot] [PATCH] package/qt5base: fix qmake parallel build Giulio Benetti
2019-04-22 17:14 ` Michael Nazzareno Trimarchi
2019-04-22 20:25 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422222528.492c48ca@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox