Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] package/bind: don't enable server by default
Date: Wed, 24 Apr 2019 22:36:05 +0200	[thread overview]
Message-ID: <20190424223605.7c21b543@windsurf> (raw)
In-Reply-To: <20190423212406.13909-3-fontaine.fabrice@gmail.com>

Hello,

On Tue, 23 Apr 2019 23:24:05 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Don't enable server by default as dhcp will now select bind to use the
> bind libraries
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/bind/Config.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/bind/Config.in b/package/bind/Config.in
> index 60546f691b..6d4ee2e6d7 100644
> --- a/package/bind/Config.in
> +++ b/package/bind/Config.in
> @@ -28,7 +28,6 @@ if BR2_PACKAGE_BIND
>  
>  config BR2_PACKAGE_BIND_SERVER
>  	bool "Install server components"
> -	default y

This will break existing defconfigs which did not explicitly enable
BR2_PACKAGE_BIND_SERVER because it was implicitly enabled when
BR2_PACKAGE_BIND=y. But I don't see a good solution to avoid that. We
certainly don't want BR2_PACKAGE_DHCP=y to install the full BIND server.

So to me, it's an acceptable trade-off. I've Cc'ed Arnout, Peter and
Yann to see what they think.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-04-24 20:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23 21:24 [Buildroot] [PATCH 1/4] package/bind: enable static build Fabrice Fontaine
2019-04-23 21:24 ` [Buildroot] [PATCH 2/4] package/bind: remove threads dependency Fabrice Fontaine
2019-04-23 21:24 ` [Buildroot] [PATCH 3/4] package/bind: don't enable server by default Fabrice Fontaine
2019-04-24 20:36   ` Thomas Petazzoni [this message]
2019-04-24 20:56     ` Arnout Vandecappelle
2019-04-25 15:56       ` Yann E. MORIN
2019-04-23 21:24 ` [Buildroot] [PATCH 4/4] package/dhcp: use system bind Fabrice Fontaine
2019-04-24 20:34 ` [Buildroot] [PATCH 1/4] package/bind: enable static build Thomas Petazzoni
2019-04-24 20:46   ` Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424223605.7c21b543@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox