From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Thu, 25 Apr 2019 17:56:31 +0200
Subject: [Buildroot] [PATCH 3/4] package/bind: don't enable server by
 default
In-Reply-To: <879be663-d6a6-ffa6-5b60-143997f65311@mind.be>
References: <20190423212406.13909-1-fontaine.fabrice@gmail.com>
 <20190423212406.13909-3-fontaine.fabrice@gmail.com>
 <20190424223605.7c21b543@windsurf>
 <879be663-d6a6-ffa6-5b60-143997f65311@mind.be>
Message-ID: <20190425155631.GC30214@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Arnout, All,

On 2019-04-24 22:56 +0200, Arnout Vandecappelle spake thusly:
> On 24/04/2019 22:36, Thomas Petazzoni wrote:
> > On Tue, 23 Apr 2019 23:24:05 +0200
> > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > 
> >> Don't enable server by default as dhcp will now select bind to use the
> >> bind libraries
> >>
> >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> >> ---
> >>  package/bind/Config.in | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/package/bind/Config.in b/package/bind/Config.in
> >> index 60546f691b..6d4ee2e6d7 100644
> >> --- a/package/bind/Config.in
> >> +++ b/package/bind/Config.in
> >> @@ -28,7 +28,6 @@ if BR2_PACKAGE_BIND
> >>  
> >>  config BR2_PACKAGE_BIND_SERVER
> >>  	bool "Install server components"
> >> -	default y
> > 
> > This will break existing defconfigs which did not explicitly enable
> > BR2_PACKAGE_BIND_SERVER because it was implicitly enabled when
> > BR2_PACKAGE_BIND=y. But I don't see a good solution to avoid that. We
> > certainly don't want BR2_PACKAGE_DHCP=y to install the full BIND server.
> > 
> > So to me, it's an acceptable trade-off. I've Cc'ed Arnout, Peter and
> > Yann to see what they think.
> 
>  Although not documented anywhere, in my opinion a defconfig is not supposed to
> be stable over upgrades. When upgrading, you should use a full config.

Agreed. The process I follow to upgrade buildroot if (roughly):

    $ make my_foo_defconfig
    $ git pull
    $ make olddefconfig
    $ diff -du .config.old .config
    $ make savedefconfig
    $ git diff   # shows delta in my_foo_defconfig

>  I also always do a diffconfig between old and new and try to understand the
> differences.

This sounds all too familiar, too. ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'