Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] meson: add entry for libgcrypt-config in cross file
Date: Wed, 1 May 2019 21:36:02 +0200	[thread overview]
Message-ID: <20190501213602.323f22eb@windsurf> (raw)
In-Reply-To: <25be7377-dabe-41b6-68b3-f9d2a2537aad@mind.be>

Hello,

On Wed, 1 May 2019 13:13:03 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:

> - I don't think it's appropriate to generate the cross-compilation.conf file in
>  PKG_BUILDDIR. I think it should be at top level, i.e. $(@D).

I'd say it depends the $(@D) of which step. Indeed, in the (admittedly
long term) perspective of per-package out-of-tree build, the source
tree would be shared between the host and target builds of a given
package, and this cross-compilation.conf file would only make sense for
the target variant of the package, and therefore it should be in the
build directory of the target variant.

So, if this file is generated during the "configure" step, we are good,
because $(@D) will point to the build directory. If it's generated in
an earlier step, $(@D) points to the source directory (with per-package
out-of-tree build implemented, of course).

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-05-01 19:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 18:32 [Buildroot] [PATCH 1/2] meson: add entry for libgcrypt-config in cross file Jörg Krause
2019-04-03 18:32 ` [Buildroot] [PATCH 2/2] package/mpd: bump to version 0.21.7 Jörg Krause
2019-04-03 19:33 ` [Buildroot] [PATCH 1/2] meson: add entry for libgcrypt-config in cross file Thomas Petazzoni
2019-04-05  6:58   ` Jörg Krause
2019-04-13 16:24 ` Thomas Petazzoni
2019-04-23 21:29   ` Peter Seiderer
2019-04-24 11:09     ` Jörg Krause
2019-04-30  8:11     ` Jörg Krause
2019-04-30  8:27       ` Peter Seiderer
2019-04-30 11:04         ` Jörg Krause
2019-05-01 11:13           ` Arnout Vandecappelle
2019-05-01 19:04             ` Peter Seiderer
2019-05-02 12:17               ` Arnout Vandecappelle
2019-05-02 20:02                 ` Peter Seiderer
2019-05-03  9:21                   ` Arnout Vandecappelle
2019-05-23 22:51                 ` Jörg Krause
2019-05-24  8:18                   ` Arnout Vandecappelle
2019-05-26  9:17                     ` Jörg Krause
2019-05-01 19:23             ` Peter Seiderer
2019-05-01 19:36             ` Thomas Petazzoni [this message]
2019-05-02 12:20               ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190501213602.323f22eb@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox