From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Seiderer Date: Wed, 8 May 2019 19:43:10 +0200 Subject: [Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote In-Reply-To: <87ef59l84u.fsf@dell.be.48ers.dk> References: <20190507203548.10337-1-ps.report@gmx.net> <20190507225224.6cde6018@windsurf> <87v9ymkmgh.fsf@dell.be.48ers.dk> <87ef59l84u.fsf@dell.be.48ers.dk> Message-ID: <20190508194310.23789f8e@gmx.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello *, On Wed, 08 May 2019 09:26:09 +0200, Peter Korsgaard wrote: > >>>>> "Arnout" == Arnout Vandecappelle writes: > > > On 07/05/2019 23:02, Peter Korsgaard wrote: > >>>>>>> "Thomas" == Thomas Petazzoni writes: > >> > >> > Hello Peter, > >> > On Tue, 7 May 2019 22:35:21 +0200 > >> > Peter Seiderer wrote: > >> > >> >> Signed-off-by: Peter Seiderer > >> >> --- > >> >> package/assimp/assimp.mk | 2 +- > >> >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> > Thanks for all those patches. I think it would be useful to extend the > >> > check-package logic to check that such UTF-8 quotes/spaces don't get > >> > re-added. > >> > >> Agreed! > > > I think in Config.in, *.mk and *.hash we should never need any non-ascii > > character, so that check would be easy. First draft, checking only the .mk files, just sent out, see [1]... > > I am not so sure about Config.in. If you look at: > > package/intel-mediasdk/Config.in > package/imagemagick/Config.in > package/zeromq/Config.in > package/directfb/Config.in > > They have UTF-8 copyright characters, a funny e in bezier and the OE in > zeromq. > - do not check (and keep as is) - whitelist for some special characters (per file?) - convert to plain ascii, e.g: (R), bezier, zeromq (without the specail zero)... Regards, Peter [1] https://patchwork.ozlabs.org/patch/1097166/