From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/uclibc: fix preadv/pwritev offset argument type
Date: Tue, 14 May 2019 18:58:00 +0200 [thread overview]
Message-ID: <20190514185800.3b4e9ea9@windsurf> (raw)
In-Reply-To: <20190513184811.20461-1-jcmvbkbc@gmail.com>
Hello Max,
Thanks for the patch and all the investigation around this issue!
On Mon, 13 May 2019 11:48:11 -0700
Max Filippov <jcmvbkbc@gmail.com> wrote:
> preadv/pwritev don't provide separate version for 64-bit wide off_t,
> and default to 32-bit wide off_t, which results in a mismatch between
> declaration and definition for user programs built with
> -D_FILE_OFFSET_BITS=64.
>
> Backported from: 423e49023eeb ("preadv/pwritev: fix offset argument type")
This Backported tag is not really relevant inside the Buildroot commit
log: indeed it refers to an upstream uClibc-ng commit. So I have moved
this line...
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> ...3-preadv-pwritev-fix-offset-argument-type.patch | 70 ++++++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 package/uclibc/0003-preadv-pwritev-fix-offset-argument-type.patch
>
> diff --git a/package/uclibc/0003-preadv-pwritev-fix-offset-argument-type.patch b/package/uclibc/0003-preadv-pwritev-fix-offset-argument-type.patch
> new file mode 100644
> index 000000000000..2a20aecc8d20
> --- /dev/null
> +++ b/package/uclibc/0003-preadv-pwritev-fix-offset-argument-type.patch
> @@ -0,0 +1,70 @@
> +From 1077d5bebffacfd4b09896ed890fb45a5b3c6dc6 Mon Sep 17 00:00:00 2001
> +From: Max Filippov <jcmvbkbc@gmail.com>
> +Date: Fri, 10 May 2019 07:13:19 -0700
> +Subject: [PATCH] preadv/pwritev: fix offset argument type
> +
> +preadv/pwritev don't provide separate version for 64-bit wide off_t,
> +and default to 32-bit wide off_t, which results in a mismatch between
> +declaration and definition for user programs built with
> +-D_FILE_OFFSET_BITS=64.
> +Make offset argument of both functions __off64_t.
> +This fixes test misc/tst-preadvwritev on xtensa.
> +
... here.
> +Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
And applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-14 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 18:48 [Buildroot] [PATCH] package/uclibc: fix preadv/pwritev offset argument type Max Filippov
2019-05-14 16:58 ` Thomas Petazzoni [this message]
2019-05-26 11:53 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514185800.3b4e9ea9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox