From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
Date: Fri, 17 May 2019 09:08:00 +0200 [thread overview]
Message-ID: <20190517090800.1ce26f4f@windsurf> (raw)
In-Reply-To: <20190517002828.GB29253@momiji>
Hello Adrian,
On Fri, 17 May 2019 00:28:28 +0300
Adrian Perez de Castro <aperez@igalia.com> wrote:
> This is not correct. The short version of the story is tat WPE WebKit
> itself does not require Wayland, only wpebackend-fdo uses Wayland.
That does not matter.
If A selects B, and B depends on C, then A *must* replicate the
"depends on C". That's due to how Kconfig work, and it's totally
unrelated to the fact that A doesn't use C directly in practice.
If you don't replicate this "depends on", then Kconfig allows you to
enable "A" even if the dependencies for "B" are not satisfied, causing
the build failure that Fabrice is fixing.
So, Fabrice patch is correct.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-17 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 20:12 [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency Fabrice Fontaine
2019-05-16 21:28 ` Adrian Perez de Castro
2019-05-17 6:43 ` Fabrice Fontaine
2019-05-17 7:08 ` Thomas Petazzoni [this message]
2019-05-17 18:09 ` Giulio Benetti
2019-05-16 21:35 ` Giulio Benetti
2019-05-16 21:38 ` Giulio Benetti
2019-05-17 18:12 ` Giulio Benetti
2019-05-18 19:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517090800.1ce26f4f@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox