Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/python-numpy: fix occasional build failure with lapack
Date: Sat, 18 May 2019 22:13:52 +0200	[thread overview]
Message-ID: <20190518221352.0630eaa6@windsurf> (raw)
In-Reply-To: <20190515210342.126951-1-giulio.benetti@micronovasrl.com>

Hello,

On Wed, 15 May 2019 23:03:42 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> python-numpy build fails only if lapack is built before python-numpy
> itself, and this doesn't always happen because lapack dependency is
> missing in BR2_PYTHON_NUMPY_DEPENDENCIES. clapack is present
> instead, but it's wrong since we're checking $(BR2_PACKAGE_LAPACK) not
> $(BR2_PACKAGE_CLAPACK).

I don't follow here: in the current code, we're checking
BR2_PACKAGE_CLAPACK and adding clapack to PYTHON_NUMPY_DEPENDENCIES,
which is consistent.

In order to better understand the problem. Without this patch:

 - Does python-numpy builds fine when neither clapack nor lapack are
   enabled ?

 - Does python-numpy builds fine when clapack is enabled, but not
   lapack ?

 - What happens when both clapack and lapack are enabled ?

Also, perhaps we need:

	select BR2_PACKAGE_LAPACK_COMPLEX if BR2_PACKAGE_LAPACK

in the Config.in file, so that it's a bit easier for users: they don't
have to know they need that specific sub-option of lapack.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-05-18 20:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 14:41 [Buildroot] [PATCH] package/python-numpy: fix occasional build failure with lapack Giulio Benetti
2019-05-15 15:12 ` Yann E. MORIN
2019-05-15 19:58   ` Giulio Benetti
2019-05-15 20:50     ` Giulio Benetti
2019-05-15 21:03       ` [Buildroot] [PATCH v2] " Giulio Benetti
2019-05-18 20:13         ` Thomas Petazzoni [this message]
2019-05-19 14:47           ` Giulio Benetti
2019-05-20 17:48             ` Giulio Benetti
2019-05-20 17:49               ` Giulio Benetti
2019-05-26  9:43                 ` Arnout Vandecappelle
2019-05-26 10:11                   ` Giulio Benetti
2019-05-26 11:43                   ` Peter Korsgaard
2019-05-26 12:29                     ` Arnout Vandecappelle
2019-05-28  5:34                       ` Benjamin Kamath
2019-07-03 20:48                         ` Romain Naour
2019-05-28 14:57                       ` Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190518221352.0630eaa6@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox