From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 20 May 2019 22:21:50 +0200 Subject: [Buildroot] [PATCH v3 2/2] package/murata-cyw-fw: download NVRAM and BT_PATCH only when needed In-Reply-To: <20190510083505.1341-3-m.niestroj@grinn-global.com> References: <20190510083505.1341-1-m.niestroj@grinn-global.com> <20190510083505.1341-3-m.niestroj@grinn-global.com> Message-ID: <20190520222150.5feafcf5@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Marcin, On Fri, 10 May 2019 10:35:05 +0200 Marcin Niestroj wrote: > Do not download NVRAM and BT_PATCH repositories when selected modules do > not require files from them. One of the example module is CYW4359, which > has neither NVRAM nor BT_PATCH files. > > There is also drawback of this approach: NVRAM and BT_PATCH are not > downloaded when package is being rebuilt with changed set selected > modules, so the whole build fails because of missing files. > > Signed-off-by: Marcin Niestroj > --- > Changes v2 -> v3: add this patch I looked at the size of the different tarballs: -rw-r--r-- 1 thomas thomas 193K 20 mai 21:53 cyw-bt-patch-748462f0b02ec4aeb500bedd60780ac51c37be31.tar.gz -rw-r--r-- 1 thomas thomas 12K 20 mai 21:53 cyw-fmac-nvram-d27f1bf105fa1e5b828e355793b88d4b66188411.tar.gz -rw-r--r-- 1 thomas thomas 2,7M 20 mai 21:53 murata-cyw-fw-8d87950bfad28c65926695b7357bd8995b60016a.tar.gz So the main tarball is 2.7 MB, and it gets always downloaded. The other ones are 193 KB and 12 KB. I don't think this really warrants some additional complexity: we can simply always download all tarballs, as you did in PATCH 1/2. So I marked PATCH 2/2 as Rejected. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com