From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 26 May 2019 21:26:21 +0200 Subject: [Buildroot] [RFC PATCH 1/4] configs/bananapro_defconfig: bump Linux to 5.1.1 In-Reply-To: <20190520193223.14071-1-b.bilas@grinn-global.com> References: <20190520193223.14071-1-b.bilas@grinn-global.com> Message-ID: <20190526212621.52c5c474@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Mon, 20 May 2019 21:32:20 +0200 Bartosz Bilas wrote: > Signed-off-by: Bartosz Bilas > --- > configs/bananapro_defconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Why did you split your changes into four patches ? As I understand it, the current bananapro_defconfig already supports WiFi, so if the bump to Linux 5.1.1 breaks WiFi and requires the fixes of the three other patches, then you should have a single patch that does all. Without this, you break bisectability: if I apply only your PATCH 1/4, then the WiFi feature which was working is no longer working. Of course, if WiFi was in fact not working with the current defconfig (i.e before any of your patches), then it's fine to split the patches. Just perhaps patches 2, 3 and 4 could be the same, because it's all about making WiFi work. Could you clarify this point, and send a new iteration ? Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com