From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/5] package/gstreamer1/gst1-plugins-bad: Add bluez plugin
Date: Sun, 26 May 2019 21:31:57 +0200 [thread overview]
Message-ID: <20190526213157.36f34149@windsurf> (raw)
In-Reply-To: <20190509224624.80437-7-aduskett@gmail.com>
Hello,
On Thu, 9 May 2019 18:46:24 -0400
aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Currently there is no explicit way to turn the bluez plugin on or off.
> Create a menu entry allowing users to disable or enable the plugin.
>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> package/gstreamer1/gst1-plugins-bad/Config.in | 10 ++++++++++
> .../gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 2 +-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
> index 35d6bddd05..b0b253bf12 100644
> --- a/package/gstreamer1/gst1-plugins-bad/Config.in
> +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
> @@ -308,6 +308,16 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_ASSRENDER
> bool "assrender"
> select BR2_PACKAGE_LIBASS
>
> +config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_BLUEZ
> + bool "bluez"
> + depends on !BR2_STATIC_LIBS
In this case, I think propagating all the dependencies of
BR2_PACKAGE_BLUEZ_UTILS is more appropriate. I know they are already
handled by the overall gstreamer1 dependencies, but I believe it is not
unlikely that the dependencies of gstreamer1 change, and for this
reason, replicating the complete bluez_utils dependencies make sense.
I know we don't have a very strict rule about this, so it's really just
a feeling for this specific case.
Besides that, bluez_utils is kinda deprecated. What about bluez5_utils
support ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-26 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 22:46 [Buildroot] [PATCH 0/5] gstreamer1: Plugin work aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 1/5] package/gstreamer1/gst1-plugins-good: Add twolame plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 2/5] package/gstreamer1/gst1-plugins-good: Add jack plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 3/5] package/gstreamer1/gst1-plugins-bad: add proxy plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 4/5] package/gstreamer1/gst1-plugins-bad: add audiolatency plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 4/4] package/gstreamer1/gst1-plugins-bad: Add bluez plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 5/5] " aduskett at gmail.com
2019-05-26 19:31 ` Thomas Petazzoni [this message]
2019-05-26 19:28 ` [Buildroot] [PATCH 0/5] gstreamer1: Plugin work Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190526213157.36f34149@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox