From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/supertux: fix debug build on uclibc/musl
Date: Sun, 26 May 2019 21:45:36 +0200 [thread overview]
Message-ID: <20190526214536.479b9db9@windsurf> (raw)
In-Reply-To: <20190526191814.3942-1-fontaine.fabrice@gmail.com>
Hello,
+Arnout in Cc.
On Sun, 26 May 2019 21:18:14 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Always set CMAKE_BUILD_TYPE to Release otherwise supertux will be built
> with -pg since:
> https://github.com/SuperTux/supertux/commit/afd5f1b33c110104a7f286d6d7854157919a0a52
>
> This will result in the following build failure on uclibc or musl:
> [ 77%] Linking C executable sq_static
> CMakeFiles/sq_static.dir/sq.c.o: In function `quit':
> /home/buildroot/autobuild/instance-3/output/build/supertux-0.6.0/external/squirrel/sq/sq.c:42: undefined reference to `__gnu_mcount_nc'
>
> Fixes:
> - http://autobuild.buildroot.org/results/b0b2e25af198d01713d1e2bcf38c77ae8ffbd7de
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
So, it really seems like we want to stop using -DCMAKE_BUILD_TYPE=Debug
when BR2_ENABLE_DEBUG=y, like Arnout suggested in another thread.
Packages are adding random flags when -DCMAKE_BUILD_TYPE=Debug, it is
not really usable, as BR2_ENABLE_DEBUG should only mean "add -g to
CFLAGS".
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-26 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 19:18 [Buildroot] [PATCH 1/1] package/supertux: fix debug build on uclibc/musl Fabrice Fontaine
2019-05-26 19:45 ` Thomas Petazzoni [this message]
2019-05-26 20:15 ` Arnout Vandecappelle
2019-05-27 21:50 ` Arnout Vandecappelle
2019-06-06 15:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190526214536.479b9db9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox