From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V2 1/9] arch/csky: Add VDSP and FLOAT_ABI compiler options.
Date: Sun, 26 May 2019 22:39:59 +0200 [thread overview]
Message-ID: <20190526223959.5b471fc7@windsurf> (raw)
In-Reply-To: <1557305915-11247-1-git-send-email-guoren@kernel.org>
Hello,
On Wed, 8 May 2019 16:58:27 +0800
guoren at kernel.org wrote:
> From: Guo Ren <ren_guo@c-sky.com>
>
> We never use BR2_CSKY_DSP in buildroot
This is not true, BR2_CSKY_DSP is used:
arch/Config.in.csky: default "ck610" if (BR2_ck610 && !BR2_CSKY_FPU && !BR2_CSKY_DSP)
arch/Config.in.csky: default "ck807" if (BR2_ck807 && !BR2_CSKY_FPU && !BR2_CSKY_DSP)
arch/Config.in.csky: default "ck807e" if (BR2_ck807 && !BR2_CSKY_FPU && BR2_CSKY_DSP)
arch/Config.in.csky: default "ck807f" if (BR2_ck807 && BR2_CSKY_FPU && !BR2_CSKY_DSP)
arch/Config.in.csky: default "ck807ef" if (BR2_ck807 && BR2_CSKY_FPU && BR2_CSKY_DSP)
arch/Config.in.csky: default "ck810" if (BR2_ck810 && !BR2_CSKY_FPU && !BR2_CSKY_DSP)
arch/Config.in.csky: default "ck810e" if (BR2_ck810 && !BR2_CSKY_FPU && BR2_CSKY_DSP)
arch/Config.in.csky: default "ck810f" if (BR2_ck810 && BR2_CSKY_FPU && !BR2_CSKY_DSP)
arch/Config.in.csky: default "ck810ef" if (BR2_ck810 && BR2_CSKY_FPU && BR2_CSKY_DSP)
so as such, your patch is incorrect: you remove an option, but the
option is still being used.
If this option is not needed because in fact the DSP enhanced
instructions have never been used, then please have a patch that *ONLY*
removes the BR2_CSKY_DSP option (both its definition and where it is
used).
Then another patch that adds the BR2_CSKY_VDSP option.
And finally another that sets the BR2_GCC_TARGET_FLOAT_ABI value.
All of these topics are independent from each other, they should be in
separate patches.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-26 20:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 8:58 [Buildroot] [PATCH V2 1/9] arch/csky: Add VDSP and FLOAT_ABI compiler options guoren at kernel.org
2019-05-08 8:58 ` [Buildroot] [PATCH V2 2/9] arch/csky: Add ck860 and -mcpu " guoren at kernel.org
2019-05-26 20:43 ` Thomas Petazzoni
2019-05-27 6:43 ` Guo Ren
2019-05-08 8:58 ` [Buildroot] [PATCH V2 3/9] arch/csky: Add toolchain build framework guoren at kernel.org
2019-05-26 20:44 ` Thomas Petazzoni
2019-05-27 6:52 ` Guo Ren
2019-05-08 8:58 ` [Buildroot] [PATCH V2 4/9] package/binutils: Add C-SKY support guoren at kernel.org
2019-05-26 20:52 ` Thomas Petazzoni
2019-05-27 7:23 ` Guo Ren
2019-05-08 8:58 ` [Buildroot] [PATCH V2 5/9] package/gcc: " guoren at kernel.org
2019-05-26 20:53 ` Thomas Petazzoni
2019-05-27 7:27 ` Guo Ren
2019-05-08 8:58 ` [Buildroot] [PATCH V2 6/9] package/gdb: " guoren at kernel.org
2019-05-26 20:56 ` Thomas Petazzoni
2019-05-27 8:08 ` Guo Ren
2019-05-08 8:58 ` [Buildroot] [PATCH V2 7/9] package/glibc: " guoren at kernel.org
2019-05-26 20:57 ` Thomas Petazzoni
2019-05-27 8:11 ` Guo Ren
2019-05-08 8:58 ` [Buildroot] [PATCH V2 8/9] support/config.sub: " guoren at kernel.org
2019-05-27 20:30 ` Thomas Petazzoni
2019-05-27 22:00 ` Peter Korsgaard
2019-05-28 6:55 ` Thomas Petazzoni
2019-06-06 15:19 ` Peter Korsgaard
2019-05-08 8:58 ` [Buildroot] [PATCH V2 9/9] configs/qemu_cskyXXX_virt: new defconfig guoren at kernel.org
2019-05-13 5:46 ` [Buildroot] [PATCH V2 1/9] arch/csky: Add VDSP and FLOAT_ABI compiler options Guo Ren
2019-05-26 20:39 ` Thomas Petazzoni [this message]
2019-05-26 20:40 ` Thomas Petazzoni
2019-05-27 11:35 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190526223959.5b471fc7@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox