From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libnfc: support pcsc-lite
Date: Mon, 27 May 2019 11:15:50 +0200 [thread overview]
Message-ID: <20190527111550.4bbf2dcc@windsurf> (raw)
In-Reply-To: <CABWPoFHO0c4GoBmS0qBFhS=XGEz4qhUMF6+REWwkrngv0ZCbVg@mail.gmail.com>
Hello,
On Mon, 27 May 2019 10:27:03 +0200
Raul Hidalgo Caballero <deinok@deinok.com> wrote:
>
Here as well: please send with git send-email so that we can do a
proper review.
A few comments though:
- We need you to use your real name as the patch author and for the
Signed-off-by line
- Why are you making pcsc-lite a mandatory dependency of libnfc ?
Since libnfc builds fine today with pcsc-lite, it means it should be
an optional dependency. Either add a sub-option to enable the
different libnfc drivers, or automatically add pcsc-lite to the
dependencies if BR2_PACKAGE_PCSC_LITE=y.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-27 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 8:27 [Buildroot] [PATCH 1/1] package/libnfc: support pcsc-lite Raul Hidalgo Caballero
2019-05-27 9:15 ` Thomas Petazzoni [this message]
2019-06-01 12:25 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527111550.4bbf2dcc@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox