From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra/pkg-kconfig: do not rely on package's .config as a timestamp
Date: Fri, 31 May 2019 20:41:25 +0200 [thread overview]
Message-ID: <20190531184125.GC3173@scaer> (raw)
In-Reply-To: <87y32nwonn.fsf@dell.be.48ers.dk>
Peter, All,
On 2019-05-31 00:41 +0200, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> > Since linux-4.19, the kernel's build system internally touches its
> > .config file.
>
> > However, we currently used that file as a timestamp to detect whether
> > our kconfig fixups were to be (re)applied or not, which in turn is used
> > to decide whether we should (re)build the package or not.
>
> > But with latest kernel versions, this timestamp heuristic is now broken,
> > and we always rebuild the kernel on subsequent builds.
>
> > We fix that by introducing a spearate timestamp file of our own, which
> > we know the kernel (or the kconfig-based packages, for that matters)
> > does not use.
>
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Cc: Arnout Vandecappelle <arnout@mind.be>
>
> Committed, thanks.
Thanks.
This is also a candidate for 2019.02.x, on which it applies cleanly.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-05-31 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 18:09 [Buildroot] [PATCH] infra/pkg-kconfig: do not rely on package's .config as a timestamp Yann E. MORIN
2019-05-30 22:41 ` Peter Korsgaard
2019-05-31 18:41 ` Yann E. MORIN [this message]
2019-05-31 20:53 ` Peter Korsgaard
2019-06-06 15:33 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531184125.GC3173@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox