[Buildroot] [PATCH v3] package/dosfstools: introduce custom install routine

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Markus,

On Fri, 31 May 2019 08:32:54 -0700
Markus Mayer <mmayer@broadcom.com> wrote:

> Right. Won't I have to define the install macros as empty if they are
> supposed to be noops?
> 
> Like this:
> 
> ifeq ($(BR2_PACKAGE_DOSFSTOOLS_FATLABEL),y)
> define DOSFSTOOLS_REMOVE_FATLABEL
> ... install code here ...
> endef
> else
> # empty declaration
> define DOSFSTOOLS_REMOVE_FATLABEL
> endef
> endif

No: undefined variables in make are automatically empty, so there's no
need for this else condition. We use this principle all over Buildroot.


> > define DOSFSTOOLS_INSTALL_TARGET_CMDS
> >         $(foreach f,$(DOSFSTOOLS_INSTALL_FILES_y), \
> >                 $(INSTALL) -D -m 0744 $(@D)/src/$(f) $(TARGET_DIR)/sbin/$(f)  
> 
> 0755 I imagine? :-)

Yes, indeed, sorry.

> >         $(foreach l,$(DOSFSTOOLS_INSTALL_SYMLINKS_y), \
> >                 ln -s $(word 2,$(subst :, ,$(l))) $(TARGET_DIR)/sbin/$(word 1,$(subst :, ,$(l)))
> >         )
> > endef
> >
> > But admittedly, it becomes a bit hackish, and we don't do that anywhere
> > in Buildroot today. So probably sticking to three
> > DOSFSTOOLS_INSTALL_<foo> defines is better for now.  
> 
> This is an interesting approach. But I'll likely stick with the other one.

Yes, as I said, I think it makes more sense to stick to the simpler
approach for now.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com