From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] package/dosfstools: introduce custom install routine
Date: Fri, 31 May 2019 22:19:25 +0200 [thread overview]
Message-ID: <20190531221925.754b3cda@windsurf> (raw)
In-Reply-To: <20190531194159.2566-1-mmayer@broadcom.com>
Hello,
On Fri, 31 May 2019 12:41:59 -0700
Markus Mayer <mmayer@broadcom.com> wrote:
> We can't use dosfstools' install target, because it'll install *all*
> binaries, even the disabled ones. Also, we can't just delete dosfstools
> binaries from the target directory after installing them, because other
> packages (specifically Busybox) may provide tools of the same name, and
> we may end up deleting those instead.
>
> To avoid any issues, we create our own install routines, which only
> copy the enabled binaries into the target location.
>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
I've applied to master, after doing one change, see below.
> +define DOSFSTOOLS_INSTALL_FSCK_FAT
> + $(INSTALL) -D -m 0755 $(@D)/src/fsck.fat $(TARGET_DIR)/sbin
The destination path should be a full destination path, which includes
the file name. I fixed that in the three places.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-31 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 19:41 [Buildroot] [PATCH v4] package/dosfstools: introduce custom install routine Markus Mayer
2019-05-31 20:06 ` Yann E. MORIN
2019-05-31 20:35 ` Markus Mayer
2019-05-31 20:43 ` Yann E. MORIN
2019-05-31 20:19 ` Thomas Petazzoni [this message]
2019-06-06 15:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531221925.754b3cda@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox