From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 1 Jun 2019 09:28:02 +0200 Subject: [Buildroot] [PATCH for-next 2/3] package/swig: enable PCRE regex matching in host-swig In-Reply-To: <20190529151655.7098-2-romain.naour@gmail.com> References: <20190529151655.7098-1-romain.naour@gmail.com> <20190529151655.7098-2-romain.naour@gmail.com> Message-ID: <20190601092802.2b4102ac@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, +Arnout, Yann, Peter in Cc. On Wed, 29 May 2019 17:16:54 +0200 Romain Naour wrote: > The upcoming ogre package needs a host swig binary with PCRE > regex support. > > Signed-off-by: Romain Naour > --- > package/swig/swig.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I never really like the addition of mandatory host package dependencies just for the sake of one use case. I was considering adding a hidden BR2_PACKAGE_HOST_PCRE option for this, but since pcre takes only 17 seconds to build, maybe it was not worth the effort. So I've applied to next as-is, but I'd be interested to know what Arnout/Peter/Yann thing about adding a hidden BR2_PACKAGE_HOST_PCRE hidden option for that kind of situation. We had decided to not systematically add such options in all host packages, but that we could add some in a case-by-case basis. This case-by-case basis however will look "weird": ogre would have host-swig in its _DEPENDENCIES, but in Config.in would select BR2_PACKAGE_HOST_PCRE and not BR2_PACKAGE_HOST_SWIG. This could start getting a bit clunky. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com