From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Seiderer Date: Tue, 4 Jun 2019 18:25:59 +0200 Subject: [Buildroot] [PATCH 1/1] package/exiv2: cleanup options and licenses In-Reply-To: <8e7755d7-831f-4945-d04f-b63d9ebc67c2@mind.be> References: <20190507103639.94701-1-nicolas.serafini@sensefly.com> <20190508102742.0000138c@sensefly.com> <8e7755d7-831f-4945-d04f-b63d9ebc67c2@mind.be> Message-ID: <20190604182559.2a52cf10@gmx.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Arnout, Nicolas, On Wed, 8 May 2019 10:44:38 +0200, Arnout Vandecappelle wrote: > On 08/05/2019 10:27, Nicolas Serafini wrote: > >>> config BR2_PACKAGE_EXIV2_LENSDATA > >>> - bool "Nikon lens name database" > >>> - depends on !BR2_PACKAGE_EXIV2_COMMERCIAL > >>> + bool "Include lens data" > >> How big is this lens data? Is it worth keeping an option for it? > > Yes you are right we can remove it. The binary is only 80KB less with > > the lensdata option disabled. > > > > Do I need to add a Config.in.legacy option if I remove it. > > No, same as for the _COMMERCIAL option. The legacy handling is there to make > sure that people who update Buildroot and had some option enabled will be able > to do whatever is needed to keep the same behaviour. > > It is useful to mention explicitly in the commit message why legacy handling is > skipped. Something like: "Legacy handling for the removed options _COMMERCIAL > and _LENSDATA is not needed, since now they are always enabled." Disagree with this reasoning, o.k. for the enable-_LENSDATA option, NAK for the _COMMERCIAL one (users who selected _COMMERCIAL before will now get GPL-2.0+ without warning/notice)... Regards, Peter > > > The default > > state in exiv2 CMakeList is enabled. > > It is a good idea to still add the -D...=ON explicitly, because: > - it makes sure that the same behaviour is kept if the default changes; and > - if the option changes name, is removed, ... there is a warning in the > configure step, so there's a better chance that whoever is doing the bump will > notice it. > > Regards, > Arnout > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot