From: Atharva Lele <itsatharva@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/3] autobuild-run: initial implementation of do_reproducible_build()
Date: Fri, 7 Jun 2019 12:16:56 +0530 [thread overview]
Message-ID: <20190607064657.3571-2-itsatharva@gmail.com> (raw)
In-Reply-To: <20190607064657.3571-1-itsatharva@gmail.com>
This new function will call do_build() twice to produce two builds
and then check their reproducibility
Signed-off-by: Atharva Lele <itsatharva@gmail.com>
---
Changes v1 -> v2:
- make clean outputs to devnull (suggested by arnout)
- remove unnecessary arguments to make clean (suggested by arnout)
Signed-off-by: Atharva Lele <itsatharva@gmail.com>
---
scripts/autobuild-run | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 5d76583..a4ddb5b 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -494,6 +494,46 @@ def do_build(**kwargs):
log_write(log, "INFO: build successful")
return 0
+def do_reproducible_build(**kwargs):
+ """Run the builds for reproducibility testing
+
+ Build twice with the same configuration. Calls do_build() to
+ perform the actual build.
+ """
+
+ idir = "instance-%d" % kwargs['instance']
+ outputdir = os.path.join(idir, "output")
+ log = kwargs['log']
+
+ # Start the first build
+ log_write(log, "INFO: Reproducible Build Test, starting build 1")
+ ret = do_build(**kwargs)
+ if ret != 0:
+ log_write(log, "INFO: build 1 failed, skipping build 2")
+ return ret
+
+ # First build has been built, move files and start build 2
+ os.rename(os.path.join(outputdir, "images"), os.path.join(outputdir, "images-1"))
+
+ # Clean up build 1
+ if kwargs['debug']:
+ devnull = log
+ else:
+ devnull = open(os.devnull, "w")
+ cmd = ["make", "O=%s" % outputdir, "clean"]
+ subprocess.call(cmd, stdout=devnull, stderr=devnull)
+
+ # Start the second build
+ log_write(log, "INFO: Reproducible Build Test, starting build 2")
+ ret = do_build(**kwargs)
+ if ret != 0:
+ log_write(log, "INFO: build 2 failed")
+ return ret
+
+ # Assuming both have built successfully
+ ret = check_reproducibility(**kwargs)
+ return ret
+
def send_results(result, **kwargs):
"""Prepare and store/send tarball with results
--
2.20.1
next prev parent reply other threads:[~2019-06-07 6:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 6:46 [Buildroot] [PATCH v2 1/3] autobuild-run: initial implementation of check_reproducibility() Atharva Lele
2019-06-07 6:46 ` Atharva Lele [this message]
2019-06-07 8:33 ` [Buildroot] [PATCH v2 2/3] autobuild-run: initial implementation of do_reproducible_build() Thomas Petazzoni
2019-06-07 8:39 ` Arnout Vandecappelle
2019-06-07 8:44 ` Thomas Petazzoni
2019-06-07 8:40 ` Atharva Lele
2019-06-08 11:40 ` Arnout Vandecappelle
2019-06-07 6:46 ` [Buildroot] [PATCH v2 3/3] autobuild-run: do reproducible builds tests if BR2_REPRODUCIBLE=y Atharva Lele
2019-06-08 11:46 ` Arnout Vandecappelle
2019-06-08 11:37 ` [Buildroot] [PATCH v2 1/3] autobuild-run: initial implementation of check_reproducibility() Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607064657.3571-2-itsatharva@gmail.com \
--to=itsatharva@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox