From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Sun, 9 Jun 2019 23:45:32 +0200 Subject: [Buildroot] [PATCH 4/4] package/iputils: fix build without setcap In-Reply-To: References: <20190609093814.14169-1-fontaine.fabrice@gmail.com> <20190609093814.14169-4-fontaine.fabrice@gmail.com> Message-ID: <20190609214531.GA17515@x230> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi, > On 09/06/2019 11:38, Fabrice Fontaine wrote: > > Fixes: > > - http://autobuild.buildroot.org/results/711718ecf20d6cc28953e089a6e5516cfb4b9031 > > Signed-off-by: Fabrice Fontaine > All four applied to master, thanks. > I have a question about this one though... ... > > ++++ b/meson.build > > +@@ -221,10 +221,13 @@ config_h = configure_file( > > + setcap = find_program('setcap', '/usr/sbin/setcap', '/sbin/setcap', required : false) > Clearly, the setcap from the host is not relevant for us... > I haven't checked, but I assume this would be used to give the executables the > appropriate capabilities for non-root usage at installation time. > So, three questions: > 1. Shouldn't we do the same with an IPUTILS_PERMISSIONS setting? I removed IPUTILS_PERMISSIONS in 9ffcd9279e ("package/iputils: bump to version s20190515"), but it looks like it's better to use it (thus we don't depend on /sbin/setcap). > 2. Does this interact in any way with USE_CAP? No. > > + if get_option('NO_SETCAP_OR_SUID') > 3. Shouldn't we set this option, since we probably don't want to use > /sbin/setcap, ever? IMHO yes. > Regards, > Arnout Kind regards, Petr