From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] package/iputils: fix build without setcap
Date: Mon, 10 Jun 2019 00:34:56 +0200 [thread overview]
Message-ID: <20190609223456.GA26152@x230> (raw)
In-Reply-To: <CAPi7W80ms+GTYwC9Q6usykCFxWjA7+1FSy2-KR3qW16RFdEBPA@mail.gmail.com>
Hi,
...
> > > So, three questions:
> > > 1. Shouldn't we do the same with an IPUTILS_PERMISSIONS setting?
> > I removed IPUTILS_PERMISSIONS in 9ffcd9279e ("package/iputils: bump to version s20190515"),
> > but it looks like it's better to use it (thus we don't depend on /sbin/setcap).
> > > 2. Does this interact in any way with USE_CAP?
> > No.
Sorry, yes, in a sense that if setcap binary is on host and USE_CAP defined
than setcap-setuid.sh script would set cap_net_raw+ep.
> > > > + if get_option('NO_SETCAP_OR_SUID')
> > > 3. Shouldn't we set this option, since we probably don't want to use
> > > /sbin/setcap, ever?
> > IMHO yes.
> Thanks for your help in answering those questions.
> Could you send the patch setting back IPUTILS_PERMISSIONS and using
> NO_SETCAP_OR_SUID?
> From my understanding, permissions should be set to ping and
> traceroute6 as done before the dump but also to clockdiff and arping.
Thanks, good point. Yes, it's in meson.build, socket permission requires that.
Kind regards,
Petr
next prev parent reply other threads:[~2019-06-09 22:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 9:38 [Buildroot] [PATCH 1/4] package/iputils: fix IDN support Fabrice Fontaine
2019-06-09 9:38 ` [Buildroot] [PATCH 2/4] package/iputils: fix build with NLS Fabrice Fontaine
2019-06-09 9:38 ` [Buildroot] [PATCH 3/4] package/iputils: fix license Fabrice Fontaine
2019-06-09 9:38 ` [Buildroot] [PATCH 4/4] package/iputils: fix build without setcap Fabrice Fontaine
2019-06-09 21:36 ` Arnout Vandecappelle
2019-06-09 21:45 ` Petr Vorel
2019-06-09 22:01 ` Fabrice Fontaine
2019-06-09 22:34 ` Petr Vorel [this message]
2019-06-10 12:52 ` Arnout Vandecappelle
2019-06-09 22:39 ` Petr Vorel
2019-06-10 12:00 ` Arnout Vandecappelle
2019-06-09 21:35 ` [Buildroot] [PATCH 1/4] package/iputils: fix IDN support Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609223456.GA26152@x230 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox