Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] lmbench: mark scripts/build as bash script
Date: Thu, 13 Jun 2019 13:26:47 +0200	[thread overview]
Message-ID: <20190613132647.61a5571b@windsurf> (raw)
In-Reply-To: <20190612233934.14805-2-mmayer@broadcom.com>

Hello,

On Wed, 12 Jun 2019 16:39:33 -0700
Markus Mayer <mmayer@broadcom.com> wrote:

> While bash supports the "+=" operator for environment variables,
> /bin/sh does not. scripts/build is making use of "+=" but declares
> itself to be a /bin/sh script. This leads to errors of the form
>     ../scripts/build: 21: ../scripts/build: LDLIBS+= -lm: not found
> and doesn't change the contents of LDLIBS as was the intention.
> 
> Therefore, we change the interpreter to /bin/bash, which makes things
> work as intended.
> 
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
>  package/lmbench/0001-build_use_bash.patch | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 package/lmbench/0001-build_use_bash.patch
> 
> diff --git a/package/lmbench/0001-build_use_bash.patch b/package/lmbench/0001-build_use_bash.patch
> new file mode 100644
> index 000000000000..c68ed2ef7ac4
> --- /dev/null
> +++ b/package/lmbench/0001-build_use_bash.patch

We need all patches to have a description + Signed-off-by line.
Ideally, they should be generated using git format-patch, but since
there is apparently no upstream git repo for lmbench, that is not a
requirement.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-06-13 11:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 23:39 [Buildroot] [PATCH 0/2] lmbench patches Markus Mayer
2019-06-12 23:39 ` [Buildroot] [PATCH 1/2] lmbench: mark scripts/build as bash script Markus Mayer
2019-06-13 11:26   ` Thomas Petazzoni [this message]
2019-06-12 23:39 ` [Buildroot] [PATCH 2/2] lmbench: install the lmbench script on the target Markus Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613132647.61a5571b@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox