Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 1/4] autobuild-run: move creation of result directory to run_instance()
Date: Mon, 17 Jun 2019 20:06:09 +0200	[thread overview]
Message-ID: <20190617200609.4276a61a@windsurf> (raw)
In-Reply-To: <20190617093456.6110-1-itsatharva@gmail.com>

Hello,

On Mon, 17 Jun 2019 15:04:53 +0530
Atharva Lele <itsatharva@gmail.com> wrote:

> We need the result directory to be present when the check_reproducibility()
> function (implemented in the next patch) executes. As of now the results
> directory is created in the send_results() function which executes after
> check_reproducibility() will.
> 
> Signed-off-by: Atharva Lele <itsatharva@gmail.com>
> Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>
> 
> ---
> Changes v4: Add new patch to series
> ---
>  scripts/autobuild-run | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

I have applied the series to buildroot-test, thanks!

One thing I was not a big fan of was PATCH 1/4, perhaps the
check_reproducibility() should have stored its result in some other
place, and keep the send_result() function to collect all the result
artifacts into the results/ folder. But since it's a minor detail and
we want to move forward with this, I applied as-is.

I have just restarted the Bootlin autobuilder machine with this new
version of autobuild-run, we'll see what happens :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-06-17 18:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17  9:34 [Buildroot] [PATCH v5 1/4] autobuild-run: move creation of result directory to run_instance() Atharva Lele
2019-06-17  9:34 ` [Buildroot] [PATCH v5 2/4] autobuild-run: initial implementation of check_reproducibility() Atharva Lele
2019-06-17  9:34 ` [Buildroot] [PATCH v5 3/4] autobuild-run: initial implementation of do_reproducible_build() Atharva Lele
2019-06-17  9:34 ` [Buildroot] [PATCH v5 4/4] autobuild-run: do reproducible builds tests if BR2_REPRODUCIBLE=y Atharva Lele
2019-06-17 18:06 ` Thomas Petazzoni [this message]
2019-06-18  7:14   ` [Buildroot] [PATCH v5 1/4] autobuild-run: move creation of result directory to run_instance() Thomas Petazzoni
2019-06-18  7:34     ` Arnout Vandecappelle
2019-06-18  7:45       ` Thomas Petazzoni
2019-06-18  8:25       ` Atharva Lele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190617200609.4276a61a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox