From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 15/27] package/flann: re-enable package on microblaze
Date: Wed, 19 Jun 2019 21:53:19 +0200 [thread overview]
Message-ID: <20190619215319.6ef11005@windsurf> (raw)
In-Reply-To: <20190614210346.121013-16-giulio.benetti@micronovasrl.com>
On Fri, 14 Jun 2019 23:03:34 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> With Microblaze Gcc version <= 9.x build fails tue to bug 68485:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. To avoid this, the
> flann package has a !BR2_microblaze dependency. However, gcc bug 68485
> only triggers when optimization is enabled, so we can work around the
> issue by passing -O0, which is what we do in other Buildroot packages to
> work around this bug.
>
> So, this commit passes -O0 when BR2_TOOLCHAIN_HAS_GCC_BUG_68485, and
> re-enables flann on Microblaze.
>
> Note that the comment was talking about gcc bug 69401, but this gcc
> bug is a duplicate of 68485. Since all Buildroot packages now use the
> reference to gcc bug 68485 and the option is named
> BR2_TOOLCHAIN_HAS_GCC_BUG_68485, we use this naming as well for
> flann.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> package/flann/Config.in | 4 ----
> package/flann/flann.mk | 4 ++++
> 2 files changed, 4 insertions(+), 4 deletions(-)
I've applied to master, after changing the implementation to use a
FLANN_CXXFLAGS variable.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-06-19 19:53 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 21:03 [Buildroot] [PATCH 00/27] Microblaze clean up Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 01/27] package/keyutils: re-enable package on microblaze Giulio Benetti
2019-06-19 5:24 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 02/27] package/ecryptfs-utils: " Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 03/27] package/libnss: use correct CFLAGS and LDFLAGS Giulio Benetti
2019-06-19 12:33 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 04/27] package/libnss: re-enable package on microblaze Giulio Benetti
2019-06-19 12:34 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 05/27] package/ecryptfs-utils: remove libnss gcc bug dependency Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 06/27] package/stress-ng: re-enable package on microblaze Giulio Benetti
2019-06-19 12:36 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 07/27] package/bullet: re-enable package when gcc bug 85180 is present Giulio Benetti
2019-06-19 12:46 ` Thomas Petazzoni
2019-06-19 13:17 ` Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 08/27] package/boost: allow building on microblaze Giulio Benetti
2019-06-19 15:56 ` Thomas Petazzoni
2019-06-20 9:37 ` Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 09/27] package/boost: work around gcc bug 85180 for boost-fiber option Giulio Benetti
2019-06-19 15:58 ` Thomas Petazzoni
2019-06-20 9:39 ` Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 10/27] package/snort: work around gcc bug 85180 Giulio Benetti
2019-06-19 16:00 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 11/27] package/prboom: avoid using hardcoded optimization flags Giulio Benetti
2019-06-19 19:37 ` Thomas Petazzoni
2019-06-20 13:40 ` Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 12/27] package/prboom: work around gcc bug 85180 Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 13/27] package/kmsxx: " Giulio Benetti
2019-06-19 19:42 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 14/27] package/gpsd: use common BR2_TOOLCHAIN_HAS_GCC_BUG_68485 Giulio Benetti
2019-06-19 19:49 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 15/27] package/flann: re-enable package on microblaze Giulio Benetti
2019-06-19 19:53 ` Thomas Petazzoni [this message]
2019-06-14 21:03 ` [Buildroot] [PATCH 16/27] package/libspatialindex: use common BR2_TOOLCHAIN_HAS_BUG_68485 Giulio Benetti
2019-06-19 19:54 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 17/27] package/lua-cqueues: fix build failure due to Gcc Bug 68485 Giulio Benetti
2019-06-19 19:58 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 18/27] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_63261 Giulio Benetti
2019-06-22 17:53 ` Thomas Petazzoni
2019-06-24 9:30 ` Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 19/27] package/fxload: re-enable package on microblaze Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 20/27] package/dmalloc: " Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 21/27] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_90620 Giulio Benetti
2019-06-20 16:14 ` Thomas Petazzoni
2019-06-21 9:22 ` Giulio Benetti
2019-06-21 16:51 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 22/27] package/haproxy: re-enable package on microblaze Giulio Benetti
2019-06-20 16:13 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 23/27] package/tvheadend: fix PIE build failures Giulio Benetti
2019-06-14 21:28 ` Giulio Benetti
2019-06-20 14:36 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 24/27] package/tvheadend: re-enable package on microblaze Giulio Benetti
2019-06-20 14:36 ` Thomas Petazzoni
2019-06-14 21:03 ` [Buildroot] [PATCH 25/27] package/qt5/qt5webengine: re-enable building if BUG_85682=y on Qt5 Latest Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 26/27] package/sqlite: work around build timeout Giulio Benetti
2019-06-20 14:42 ` Thomas Petazzoni
2019-06-20 14:46 ` Giulio Benetti
2019-06-14 21:03 ` [Buildroot] [PATCH 27/27] package/flashbench: remove old toolchain microblaze & sh2a workaround Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619215319.6ef11005@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox