Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/6] package/python-pycairo: new package
Date: Thu, 20 Jun 2019 22:17:21 +0200	[thread overview]
Message-ID: <20190620221721.0cbac654@windsurf> (raw)
In-Reply-To: <20190531171654.17906-3-matthew.weber@rockwellcollins.com>

Hello,

On Fri, 31 May 2019 12:16:51 -0500
Matt Weber <matthew.weber@rockwellcollins.com> wrote:

> diff --git a/package/python-pycairo/Config.in b/package/python-pycairo/Config.in
> new file mode 100644
> index 0000000000..2d44dec85e
> --- /dev/null
> +++ b/package/python-pycairo/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_PYCAIRO
> +	bool "python-pycairo"
> +	select on BR2_PACKAGE_CAIRO # runtime dependency

"select on" is not correct, it even prevents menuconfig from starting.

Also cairo is not a runtime dependency, but a build time dependency.
With your patch applied, if you do "make python-pycairo" to just build
python-pycairo and its build dependencies, the build fails with:

>>> python-pycairo 1.18.1 Building
(cd /home/thomas/projets/buildroot/output/build/python-pycairo-1.18.1//; _PYTHON_SYSCONFIGDATA_NAME="_sysconfigdata_m_linux_arm-linux-gnueabi" PATH="/home/thomas/projets/buildroot/output/host/bin:/home/thomas/projets/buildroot/output/host/sbin:/usr/libexec/python3-sphinx:/usr/share/Modules/bin:/usr/lib64/ccache:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/home/thomas/.rvm/bin:/home/thomas/sys/bin:/home/thomas/.gem/ruby/2.1.0/bin:/home/thomas/.rvm/bin:/home/thomas/.local/bin" PYTHONPATH="/home/thomas/projets/buildroot/output/target/usr/lib/python3.7/" PYTHONNOUSERSITE=1 _python_sysroot=/home/thomas/projets/buildroot/output/host/arm-buildroot-linux-uclibcgnueabi/sysroot _python_prefix=/usr _python_exec_prefix=/usr  /home/thomas/projets/buildroot/output/host/bin/python setup.py build  )
running build
running build_py
creating build
creating build/lib.linux-x86_64-3.7
creating build/lib.linux-x86_64-3.7/cairo
copying cairo/__init__.py -> build/lib.linux-x86_64-3.7/cairo
copying cairo/__init__.pyi -> build/lib.linux-x86_64-3.7/cairo
copying cairo/py.typed -> build/lib.linux-x86_64-3.7/cairo
running build_ext
Package cairo was not found in the pkg-config search path.
Perhaps you should add the directory containing `cairo.pc'
to the PKG_CONFIG_PATH environment variable
Package 'cairo', required by 'virtual:world', not found
Command '['pkg-config', '--print-errors', '--exists', 'cairo >= 1.13.1']' returned non-zero exit status 1.

> +PYTHON_PYCAIRO_LICENSE = LGPL-2.0, MPL-1.1

The license is LGPL-2.1 or MPL-1.1

> +PYTHON_PYCAIRO_LICENSE_FILES = COPYING

Please add COPYING-LGPL-2.1 and COPYING-MPL-1.1 to the license files.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-06-20 20:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 17:16 [Buildroot] [PATCH 1/6] package/python-colorama: new package Matt Weber
2019-05-31 17:16 ` [Buildroot] [PATCH 2/6] package/python-iptables: " Matt Weber
2019-06-20 20:03   ` Thomas Petazzoni
2019-05-31 17:16 ` [Buildroot] [PATCH 3/6] package/python-pycairo: " Matt Weber
2019-06-20 20:17   ` Thomas Petazzoni [this message]
2019-05-31 17:16 ` [Buildroot] [PATCH 4/6] package/python-tinyrpc: " Matt Weber
2019-06-20 20:19   ` Thomas Petazzoni
2019-05-31 17:16 ` [Buildroot] [PATCH 5/6] package/python-txdbus: " Matt Weber
2019-06-20 20:23   ` Thomas Petazzoni
2019-05-31 17:16 ` [Buildroot] [PATCH 6/6] package/python-wsgiref: " Matt Weber
2019-06-20 20:25   ` Thomas Petazzoni
2019-06-25  9:47     ` Matthew Weber
2019-06-20 20:02 ` [Buildroot] [PATCH 1/6] package/python-colorama: " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190620221721.0cbac654@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox