Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Atharva Lele <itsatharva@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 12/19] autobuild-run: move debug from kwargs to Builder class
Date: Fri, 21 Jun 2019 14:17:23 +0530	[thread overview]
Message-ID: <20190621084730.16411-12-itsatharva@gmail.com> (raw)
In-Reply-To: <20190621084730.16411-1-itsatharva@gmail.com>

Signed-off-by: Atharva Lele <itsatharva@gmail.com>
---
 scripts/autobuild-run | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 7c3e891..0db2995 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -274,7 +274,7 @@ class Builder:
     def __init__(self, instance, njobs, sysinfo,
                  http_url, http_login, http_password,
                  submitter, make_opts, nice, toolchains_csv,
-                 repo, upload, buildpid):
+                 repo, upload, buildpid, debug):
         self.instance = instance
         self.njobs = njobs
         self.sysinfo = sysinfo
@@ -288,6 +288,7 @@ class Builder:
         self.repo = repo
         self.upload = upload
         self.buildpid = buildpid
+        self.debug = debug
 
     def prepare_build(self, **kwargs):
         """Prepare for the next build of the specified instance
@@ -378,7 +379,7 @@ class Builder:
 
         log_write(log, "INFO: generate the configuration")
 
-        if kwargs['debug']:
+        if self.debug:
             devnull = log
         else:
             devnull = open(os.devnull, "w")
@@ -724,7 +725,7 @@ class Builder:
         if not os.path.exists(idir):
             os.mkdir(idir)
 
-        if kwargs['debug']:
+        if self.debug:
             kwargs['log'] = sys.stdout
         else:
             kwargs['log'] = open(os.path.join(idir, "instance.log"), "a+")
@@ -861,10 +862,8 @@ def main():
                           args['--http-login'], args['--http-password'],
                           args['--submitter'], (args['--make-opts'] or ''),
                           (args['--nice'] or 0), args['--toolchains-csv'],
-                          args['--repo'], upload, buildpid)
-        p = multiprocessing.Process(target=builder.run_instance, kwargs=dict(
-                debug = args['--debug']
-            ))
+                          args['--repo'], upload, buildpid, args['--debug'])
+        p = multiprocessing.Process(target=builder.run_instance)
         p.start()
         processes.append(p)
 
-- 
2.20.1

  parent reply	other threads:[~2019-06-21  8:47 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21  8:47 [Buildroot] [PATCH 01/19] autobuild-run: introduce Builder class Atharva Lele
2019-06-21  8:47 ` [Buildroot] [PATCH 02/19] autobuild-run: move instance variable from kwargs to " Atharva Lele
2019-06-24 20:31   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 03/19] autobuild-run: move njobs " Atharva Lele
2019-06-24 21:34   ` Arnout Vandecappelle
2019-06-25  4:53     ` Atharva Lele
2019-06-21  8:47 ` [Buildroot] [PATCH 04/19] autobuild-run: move sysinfo " Atharva Lele
2019-06-24 21:35   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 05/19] autobuild-run: move http variables " Atharva Lele
2019-06-24 21:36   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 06/19] autobuild-run: move submitter " Atharva Lele
2019-06-24 21:38   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 07/19] autobuild-run: move niceness " Atharva Lele
2019-06-24 21:38   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 08/19] autobuild-run: move toolchains_csv " Atharva Lele
2019-06-24 21:37   ` Arnout Vandecappelle
2019-06-25  5:01     ` Atharva Lele
2019-06-25  8:08       ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 09/19] autobuild-run: move repo " Atharva Lele
2019-06-24 21:39   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 10/19] autobuild-run: move upload variable " Atharva Lele
2019-06-24 21:40   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 11/19] autobuild-run: move buildpid " Atharva Lele
2019-06-24 21:41   ` Arnout Vandecappelle
2019-06-21  8:47 ` Atharva Lele [this message]
2019-06-24 21:43   ` [Buildroot] [PATCH 12/19] autobuild-run: move debug " Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 13/19] autobuild-run: define instance directory as a part of " Atharva Lele
2019-06-24 21:44   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 14/19] autobuild-run: move log variable to " Atharva Lele
2019-06-25 14:20   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 15/19] autobuild-run: remove kwargs argument from function calls and definitions Atharva Lele
2019-06-25 20:03   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 16/19] autobuild-run: define source directory as part of Builder class Atharva Lele
2019-06-25 20:07   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 17/19] autobuild-run: define download " Atharva Lele
2019-06-25 20:08   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 18/19] autobuild-run: define output " Atharva Lele
2019-06-25 20:10   ` Arnout Vandecappelle
2019-06-21  8:47 ` [Buildroot] [PATCH 19/19] autobuild-run: define results " Atharva Lele
2019-06-25 20:10   ` Arnout Vandecappelle
2019-06-24 21:22 ` [Buildroot] [PATCH 01/19] autobuild-run: introduce " Arnout Vandecappelle
2019-06-25  4:50   ` Atharva Lele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621084730.16411-12-itsatharva@gmail.com \
    --to=itsatharva@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox