From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] autobuild-run: create reason file on build failures
Date: Sat, 22 Jun 2019 20:49:57 +0200 [thread overview]
Message-ID: <20190622204957.587b1635@windsurf> (raw)
In-Reply-To: <20190622184118.5627-1-itsatharva@gmail.com>
Hello Atharva,
Thanks for the second iteration. One question below.
On Sun, 23 Jun 2019 00:11:16 +0530
Atharva Lele <itsatharva@gmail.com> wrote:
> + reason = get_failure_reason()
> + if reason:
> + with open(os.path.join(self.resultdir, "reason"), "w+") as reasonf:
> + reasonf.write("-".join(reason))
Why do we have this "-".join(reason) instead of just writing the
contents of the "reason" variable to the file ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-06-22 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-22 18:41 [Buildroot] [PATCH v2 1/3] autobuild-run: create reason file on build failures Atharva Lele
2019-06-22 18:41 ` [Buildroot] [PATCH v2 2/3] autobuild-run: account for reproducibility failures when creating the reason file Atharva Lele
2019-06-22 18:41 ` [Buildroot] [PATCH v2 3/3] web/import.inc.php: support reading failure reason from " Atharva Lele
2019-06-22 18:49 ` Thomas Petazzoni [this message]
2019-06-22 19:13 ` [Buildroot] [PATCH v2 1/3] autobuild-run: create reason file on build failures Atharva Lele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190622204957.587b1635@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox