From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Sun, 23 Jun 2019 17:24:16 +0200
Subject: [Buildroot] [PATCHv2] meson: add per package optional
 compiler/linker flags
In-Reply-To: <20190623123614.677b10fd@windsurf>
References: <20190622202046.21817-1-yann.morin.1998@free.fr>
 <20190623123614.677b10fd@windsurf>
Message-ID: <20190623152416.GH13664@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Thomas, All,

On 2019-06-23 12:36 +0200, Thomas Petazzoni spake thusly:
> On Sat, 22 Jun 2019 22:20:46 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> 
> Perhaps the commit should explain that as of today, Meson doesn't allow
> to pass cflags/ldflags on the command line when a cross-compilation
> file is used.

Indeed.

[--SNIP--]
> > +* +FOO_CFLAGS+, to specify compiler arguments added to the package specific
> > +  +cross-compile.conf+ file +c_args+ property. By default, empty, so that
> > +  the global +TARGET_CFLAGS+ are used.
> 
> I find the wording "By default, empty, so that the global
> +TARGET_CFLAGS+ are used" very confusing. Indeed, by default, those
> variables are not empty, they are precisely defined to TARGET_CFLAGS.
> 
> For example, in the autotools infra documentation, we say:
> 
> * +LIBFOO_AUTORECONF+, tells whether the package should
>   be autoreconfigured or not (i.e. if the configure script and
>   Makefile.in files should be re-generated by re-running autoconf,
>   automake, libtool, etc.). Valid values are +YES+ and
>   +NO+. By default, the value is +NO+
> 
> So we just say that the default value is NO, not that it is empty and
> that NO is used :)
> 
> For extra clarity, it could be rephrased like this:
> 
> 	When no value is specified by the package for this variable,
> 	the value of +TARGET_CFLAGS+ will be used by the
> 	+meson-package+ infrastructure.

Yes, that makes sense.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'