Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/imagemagick: add prompt for host variant
Date: Sun, 23 Jun 2019 18:00:37 +0200	[thread overview]
Message-ID: <20190623180037.1b7a3cc3@windsurf> (raw)
In-Reply-To: <3833_1550582141_5C6C017D_3833_428_1_8b3762a4-694a-45cd-8cac-301fd3ba7526@OPEXCLILMA1.corporate.adroot.infra.ftgroup>

Hello,

On Tue, 19 Feb 2019 14:15:29 +0100
<yann.morin@orange.com> wrote:

> diff --git a/linux/Config.in b/linux/Config.in
> index 323ba38d72..8466332dfe 100644
> --- a/linux/Config.in
> +++ b/linux/Config.in
> @@ -2,6 +2,7 @@ menu "Kernel"
>  
>  config BR2_LINUX_KERNEL
>  	bool "Linux Kernel"
> +	select BR2_PACKAGE_HOST_IMAGEMAGICK if BR2_LINUX_KERNEL_CUSTOM_LOGO_PATH != ""

We don't really consistently select the option of host packages. For
example, pkgconf has a host option, and we clearly don't select from
all the packages that have a dependency on host-pkgconf.

But well, it doesn't hurt to do so, especially in this case where
there's only one location which selects host-imagemagick.

> +	bool "host-imagemagick"

We use "host foo" as the prompt for host packages and not "host-foo",
so I tweaked this.

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-06-23 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190219131530.16364-1-yann.morin@orange.com>
2019-02-19 13:15 ` [Buildroot] [PATCH 2/3] package/imagemagick: add prompt for host variant yann.morin at orange.com
2019-06-23 16:00   ` Thomas Petazzoni [this message]
2019-02-19 13:15 ` [Buildroot] [PATCH 3/3] package/imagemagick: add optional SVG support to " yann.morin at orange.com
2019-06-23 16:01   ` Thomas Petazzoni
2019-06-23 19:31     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190623180037.1b7a3cc3@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox