Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] initramfs: drop comment against multiple formats
Date: Sun, 23 Jun 2019 18:09:32 +0200	[thread overview]
Message-ID: <20190623180932.09bb8cfe@windsurf> (raw)
In-Reply-To: <20190126001901.3090-1-vivien.didelot@gmail.com>

Hello Vivien,

On Fri, 25 Jan 2019 19:19:01 -0500
Vivien Didelot <vivien.didelot@gmail.com> wrote:

> This patch removes an old comment against having multiple filesystem
> formats which doesn't bring any value.
> 
> It is also wrong per-se: one may want to use Buildroot to prepare a
> custom distribution containing a kernel+initramfs and a persistent
> default rootfs to pivot to.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>

I understand your point, but I think we need to keep a comment. Indeed,
the use-cases for generating both an initramfs and another rootfs image
are very specific, and users (especially newcomers!) should still
understand that when building an initramfs with Buildroot, it's the
entire root filesystem that goes in the initramfs.

Perhaps we should reword it like this:

	Note that enabling this initramfs option together with another
	filesystem format may not make sense: you would end up having
	two identical root filesystems, one embedded inside the kernel
	image (initramfs) and one separately. Indeed, Buildroot is
	unable to generate an initramfs with different contents than
	the root filesystem. However, we still allow generating both an
	initramfs and a normal rootfs image in the same configuration
	as they are some specific use-cases for it.

Would that work for you ?

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-06-23 16:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26  0:19 [Buildroot] [PATCH] initramfs: drop comment against multiple formats Vivien Didelot
2019-01-26  9:56 ` Peter Korsgaard
2019-01-26 16:59   ` Vivien Didelot
2019-06-23 16:09 ` Thomas Petazzoni [this message]
2019-06-25 15:14   ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190623180932.09bb8cfe@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox