Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/harfbuzz: fix build without cairo-svg
Date: Sun, 23 Jun 2019 20:58:07 +0200	[thread overview]
Message-ID: <20190623205807.02d2cd3e@windsurf> (raw)
In-Reply-To: <20190623185232.61138-1-james.hilliard1@gmail.com>

On Sun, 23 Jun 2019 12:52:32 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Fixes:
> test-ot-color.cc:40:10: fatal error: cairo-svg.h: No such file or directory
>    40 | #include <cairo-svg.h>
>       |          ^~~~~~~~~~~~~
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Hum, we fixed the same build issue with:

  https://git.buildroot.org/buildroot/commit/?id=ced273e4f1a0048319441a01be367c0bb65f6a2d

But probably your change is better, if the SVG dependency is in fact
not really needed ?

Fabrice, could you look at James patch and tell what you think ?

James: such patches should contain a reference to the autobuilder
failure it's fixing, like this:

Fixes:

  http://autobuild.buildroot.org/results/.../

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-06-23 18:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-23 18:52 [Buildroot] [PATCH 1/1] package/harfbuzz: fix build without cairo-svg James Hilliard
2019-06-23 18:58 ` Thomas Petazzoni [this message]
2019-06-23 19:01   ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190623205807.02d2cd3e@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox