Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: aduskett at gmail.com <aduskett@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v12 5/6] package/qemu: drop host kernel version check
Date: Sun, 23 Jun 2019 17:23:41 -0400	[thread overview]
Message-ID: <20190623212342.41809-6-aduskett@gmail.com> (raw)
In-Reply-To: <20190623212342.41809-1-aduskett@gmail.com>

From: Adam Duskett <Aduskett@gmail.com>

There is no clean way to check if a program will actually run using host-qemu,
making this check too restrictive.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
Changes v11 - v12:
  - Re-add this patch to the series as it was missing in V11.
Changes v1 -> v10:
  - Add this patch to the series.

 package/qemu/qemu.mk | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 73e0778d73..c57126b486 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -240,28 +240,6 @@ ifneq ($(HOST_QEMU_HOST_SYSTEM_TYPE),Linux)
 $(error "qemu-user can only be used on Linux hosts")
 endif
 
-# kernel version as major*256 + minor
-HOST_QEMU_HOST_SYSTEM_VERSION = $(shell uname -r | awk -F. '{ print $$1 * 256 + $$2 }')
-HOST_QEMU_TARGET_SYSTEM_VERSION = $(shell echo $(BR2_TOOLCHAIN_HEADERS_AT_LEAST) | awk -F. '{ print $$1 * 256 + $$2 }')
-HOST_QEMU_COMPARE_VERSION = $(shell test $(HOST_QEMU_HOST_SYSTEM_VERSION) -ge $(HOST_QEMU_TARGET_SYSTEM_VERSION) && echo OK)
-
-#
-# The principle of qemu-user is that it emulates the instructions of
-# the target architecture when running the binary, and then when this
-# binary does a system call, it converts this system call into a
-# system call on the host machine. This mechanism makes an assumption:
-# that the target binary will not do system calls that do not exist on
-# the host. This basically requires that the target binary should be
-# built with kernel headers that are older or the same as the kernel
-# version running on the host machine.
-#
-
-ifeq ($(BR_BUILDING),y)
-ifneq ($(HOST_QEMU_COMPARE_VERSION),OK)
-$(error "Refusing to build qemu-user: target Linux version newer than host's.")
-endif
-endif # BR_BUILDING
-
 else # BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE
 HOST_QEMU_OPTS += --disable-linux-user
 endif # BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE
-- 
2.21.0

  parent reply	other threads:[~2019-06-23 21:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-23 21:23 [Buildroot] [PATCH v12 0/6] gobject-introspection: new package aduskett at gmail.com
2019-06-23 21:23 ` [Buildroot] [PATCH v12 1/6] package/libiberty: " aduskett at gmail.com
2019-06-23 21:23 ` [Buildroot] [PATCH v12 2/6] package/prelink-cross: " aduskett at gmail.com
2019-06-23 21:23 ` [Buildroot] [PATCH v12 3/6] package/gdb: depend on libiberty aduskett at gmail.com
2019-06-23 21:23 ` [Buildroot] [PATCH v12 4/6] package/meson: prevent python include path manipulation aduskett at gmail.com
2019-06-23 21:23 ` aduskett at gmail.com [this message]
2019-08-03 22:27   ` [Buildroot] [PATCH v12 5/6] package/qemu: drop host kernel version check Arnout Vandecappelle
2019-06-23 21:23 ` [Buildroot] [PATCH v12 6/6] package/gobject-introspection: new package aduskett at gmail.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190623212342.41809-6-aduskett@gmail.com \
    --to=aduskett@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox