Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Atharva Lele <itsatharva@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 18/27] autobuild-run: define download directory as part of Builder class
Date: Thu,  4 Jul 2019 00:01:50 +0530	[thread overview]
Message-ID: <20190703183159.3415-18-itsatharva@gmail.com> (raw)
In-Reply-To: <20190703183159.3415-1-itsatharva@gmail.com>

Signed-off-by: Atharva Lele <itsatharva@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 scripts/autobuild-run | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 741d316..84b4dee 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -293,6 +293,7 @@ class Builder:
         # frequently needed directories
         self.idir = "instance-%d" % self.instance
         self.srcdir = os.path.join(self.idir, "buildroot")
+        self.dldir = os.path.join(self.idir, "dl")
 
         if self.debug:
             self.log = sys.stdout
@@ -310,9 +311,8 @@ class Builder:
         log_write(self.log, "INFO: preparing a new build")
 
         # Create the download directory if it doesn't exist
-        dldir = os.path.join(self.idir, "dl")
-        if not os.path.exists(dldir):
-            os.mkdir(dldir)
+        if not os.path.exists(self.dldir):
+            os.mkdir(self.dldir)
 
         # recursively find files under root
         def find_files(root):
@@ -332,12 +332,12 @@ class Builder:
         # regularly re-download files to check that their upstream
         # location is still correct.
         for i in range(0, 5):
-            flist = list(find_files(dldir))
+            flist = list(find_files(self.dldir))
             if not flist:
                 break
             f = flist[randint(0, len(flist) - 1)]
             log_write(self.log, "INFO: removing %s from downloads" %
-                      os.path.relpath(f, dldir))
+                      os.path.relpath(f, self.dldir))
             os.remove(f)
 
         branch = get_branch()
@@ -457,14 +457,13 @@ class Builder:
         # path to the output directory here is not relative to the
         # Buildroot sources, but to the location of the autobuilder
         # script.
-        dldir = os.path.abspath(os.path.join(self.idir, "dl"))
         outputdir = os.path.abspath(os.path.join(self.idir, "output"))
         f = open(os.path.join(outputdir, "logfile"), "w+")
         log_write(self.log, "INFO: build started")
 
         cmd = ["nice", "-n", str(self.nice),
                "make", "O=%s" % outputdir,
-               "-C", self.srcdir, "BR2_DL_DIR=%s" % dldir,
+               "-C", self.srcdir, "BR2_DL_DIR=%s" % self.dldir,
                "BR2_JLEVEL=%s" % self.njobs] \
             + self.make_opts.split()
         sub = subprocess.Popen(cmd, stdout=f, stderr=f)
@@ -497,7 +496,7 @@ class Builder:
             return -1
 
         cmd = ["make", "O=%s" % outputdir, "-C", self.srcdir,
-               "BR2_DL_DIR=%s" % dldir, "legal-info"] \
+               "BR2_DL_DIR=%s" % self.dldir, "legal-info"] \
             + self.make_opts.split()
         ret = subprocess.call(cmd, stdout=f, stderr=f)
         if ret != 0:
-- 
2.22.0

  parent reply	other threads:[~2019-07-03 18:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-03 18:31 [Buildroot] [PATCH v2 01/27] autobuild-run: introduce Builder class Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 02/27] autobuild-run: move instance variable from kwargs to " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 03/27] autobuild-run: move njobs " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 04/27] autobuild-run: move sysinfo " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 05/27] autobuild-run: move http variables " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 06/27] autobuild-run: move submitter " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 07/27] autobuild-run: move make_opts " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 08/27] autobuild-run: move niceness " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 09/27] autobuild-run: move toolchains_csv " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 10/27] autobuild-run: move repo " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 11/27] autobuild-run: move upload variable " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 12/27] autobuild-run: move buildpid " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 13/27] autobuild-run: move debug " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 14/27] autobuild-run: define instance directory as a part of " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 15/27] autobuild-run: move log variable to " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 16/27] autobuild-run: remove kwargs argument from function calls and definitions Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 17/27] autobuild-run: define source directory as part of Builder class Atharva Lele
2019-07-03 18:31 ` Atharva Lele [this message]
2019-07-03 18:31 ` [Buildroot] [PATCH v2 19/27] autobuild-run: define output " Atharva Lele
2019-07-04 17:36   ` Arnout Vandecappelle
2019-07-03 18:31 ` [Buildroot] [PATCH v2 20/27] autobuild-run: define results " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 21/27] autobuild-run: move check_version() to " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 22/27] autobuild-run: move get_branch() " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 23/27] scripts/autobuild-run: make the HTTP URL really configurable Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 24/27] autobuild-run: create reason file on build failures Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 25/27] autobuild-run: account for reproducibility failures when creating the reason file Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 26/27] web/import.inc.php: support reading failure reason from " Atharva Lele
2019-07-03 18:31 ` [Buildroot] [PATCH v2 27/27] scripts/autobuild-run: support changing repo Atharva Lele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190703183159.3415-18-itsatharva@gmail.com \
    --to=itsatharva@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox