Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/pkg-generic: allow to use <pkg>_DL_VERSION in packages .mk files
Date: Wed, 10 Jul 2019 18:12:43 +0200	[thread overview]
Message-ID: <20190710181243.091b99c6@windsurf> (raw)
In-Reply-To: <20190709074551.22747-2-victor.huesca@bootlin.com>

Hello Victor,

Thanks for the work on cleaning up those version variables!

On Tue,  9 Jul 2019 09:45:49 +0200
Victor Huesca <victor.huesca@bootlin.com> wrote:

> This patch continue the work done here http://buildroot-busybox.2317881.n4.nabble.com/PATCH-0-4-Sanetize-packages-version-tp225554.html
> By making this DL_VERSION public we should be able to handle the missing corner-cases
> with package version sanitizeing.
> 
> Signed-off-by: Victor Huesca <victor.huesca@bootlin.com>

I just want to point out that this patch makes <pkg>_DL_VERSION a
"public" variable, so it needs to be documented in the Buildroot
manual. It should be done in a patch in the same patch series.

Also, nitpick: make sure to wrap your commit messages (and generally
e-mails) at 72 characters.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-07-10 16:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  7:45 [Buildroot] [PATCH 0/3] continue sanitizing '<pkg>_VERSION' variable Victor Huesca
2019-07-09  7:45 ` [Buildroot] [PATCH 1/3] package/pkg-generic: allow to use <pkg>_DL_VERSION in packages .mk files Victor Huesca
2019-07-09 18:30   ` Arnout Vandecappelle
2019-07-10 11:15     ` Victor Huesca
2019-07-10 16:12   ` Thomas Petazzoni [this message]
2019-07-09  7:45 ` [Buildroot] [PATCH 2/3] package: remove common prefix/suffix from git-fetched packages Victor Huesca
2019-07-09  7:45 ` [Buildroot] [PATCH 3/3] package: remove non-conventional " Victor Huesca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710181243.091b99c6@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox