From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 10/15] arch/arm: some cores have a different name with gcc-9
Date: Sat, 13 Jul 2019 23:33:11 +0200 [thread overview]
Message-ID: <20190713213311.GG2680@scaer> (raw)
In-Reply-To: <3271a2ff-fcd9-6169-a59e-6f29fca3c34f@mind.be>
Arnout, All,
Thanks for eventually applying the series. :-)
On 2019-07-13 23:13 +0200, Arnout Vandecappelle spake thusly:
> On 20/06/2019 12:07, Giulio Benetti wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> [snip]
> > The ordering of the 'default' clauses in kconfig is important, with the
> > first default which conditions is satisfied, to be used, so we just add
> > the new core names under a more liberal condition than the older names.
>
> This is not so readable / readily understandable, IMO. Therefore, I've changed
> this into:
We depend on the default ordering in other places as well.
> [snip]
> > + default "thunderx" if BR2_thunderx && !BR2_TOOLCHAIN_GCC_AT_LEAST_9
> > + default "octeontx" if BR2_thunderx
>
> default "thunderx" if BR2_thunderx && !BR2_TOOLCHAIN_GCC_AT_LEAST_9
> default "octeontx" if BR2_thunderx && BR2_TOOLCHAIN_GCC_AT_LEAST_9
You and I reallt have a differnt way toi see things, because I find this
less readable now...
But oh well...
Thanks for applying anyway. :-)
Regards,
Yann E. MORIN.
> etc.
>
> Regards,
> Arnout
>
> > + default "thunderxt81" if BR2_thunderxt81 && !BR2_TOOLCHAIN_GCC_AT_LEAST_9
> > + default "octeontx81" if BR2_thunderxt81
> > + default "thunderxt83" if BR2_thunderxt83 && !BR2_TOOLCHAIN_GCC_AT_LEAST_9
> > + default "octeontx83" if BR2_thunderxt83
> > default "thunderxt88" if BR2_thunderxt88
> > default "thunderxt88p1" if BR2_thunderxt88p1
> > default "xgene1" if BR2_xgene1
> >
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-07-13 21:33 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 10:07 [Buildroot] [PATCH v4 00/15] Add gcc 9.1 Giulio Benetti
2019-06-20 10:07 ` [Buildroot] [PATCH v4 01/15] package/glibc/arc: fix build issue with gcc-9.1 Giulio Benetti
2019-06-22 18:58 ` Thomas Petazzoni
2019-06-20 10:07 ` [Buildroot] [PATCH v4 02/15] linux: disable Werror for powerpc kernels Giulio Benetti
2019-06-22 18:59 ` Thomas Petazzoni
2019-06-24 20:15 ` Peter Korsgaard
2019-06-25 3:05 ` Baruch Siach
2019-06-25 6:18 ` Peter Korsgaard
2019-06-20 10:07 ` [Buildroot] [PATCH v4 03/15] package/uclibc: remove asm constraint Giulio Benetti
2019-06-22 19:31 ` Thomas Petazzoni
2019-06-20 10:07 ` [Buildroot] [PATCH v4 04/15] toolchain: add gcc 9 entry Giulio Benetti
2019-06-22 19:39 ` Thomas Petazzoni
2019-06-20 10:07 ` [Buildroot] [PATCH v4 05/15] package/gcc: add support for gcc 9.1 Giulio Benetti
2019-06-22 19:40 ` Thomas Petazzoni
2019-06-20 10:07 ` [Buildroot] [PATCH v4 06/15] arch: add BR2_ARCH_NEEDS_GCC_AT_LEAST_9 Giulio Benetti
2019-06-22 19:41 ` Thomas Petazzoni
2019-06-23 9:26 ` Peter Korsgaard
2019-06-20 10:07 ` [Buildroot] [PATCH v4 07/15] toolchain-external: add gcc 9 entry Giulio Benetti
2019-06-22 19:42 ` Thomas Petazzoni
2019-06-20 10:07 ` [Buildroot] [PATCH v4 08/15] package/gcc: switch to gcc 8.x as the default Giulio Benetti
2019-06-22 19:44 ` Thomas Petazzoni
2019-06-22 22:35 ` Romain Naour
2019-06-23 16:21 ` Thomas Petazzoni
2019-06-24 6:35 ` Peter Korsgaard
2019-06-25 22:25 ` Arnout Vandecappelle
2019-06-26 6:55 ` Romain Naour
2019-06-26 7:23 ` Thomas Petazzoni
2019-06-26 7:34 ` Romain Naour
2019-06-26 6:55 ` Thomas Petazzoni
2019-06-23 9:29 ` Peter Korsgaard
2019-06-20 10:07 ` [Buildroot] [PATCH v4 09/15] arch/arm: move dependency on 64-bit down to individual cores Giulio Benetti
2019-07-13 21:11 ` Arnout Vandecappelle
2019-06-20 10:07 ` [Buildroot] [PATCH v4 10/15] arch/arm: some cores have a different name with gcc-9 Giulio Benetti
2019-07-13 21:13 ` Arnout Vandecappelle
2019-07-13 21:33 ` Yann E. MORIN [this message]
2019-06-20 10:07 ` [Buildroot] [PATCH v4 11/15] arch/arm: saphira is in fact an armv8.4a Giulio Benetti
2019-06-20 10:07 ` [Buildroot] [PATCH v4 12/15] arch/arm: add two new 64-bit-only armv8a cores Giulio Benetti
2019-06-20 10:07 ` [Buildroot] [PATCH v4 13/15] arch/arm: add two new cortex-based armv8.2a cores Giulio Benetti
2019-06-20 10:07 ` [Buildroot] [PATCH v4 14/15] arch/arm: add two new non-cortex-based " Giulio Benetti
2019-07-13 21:22 ` Arnout Vandecappelle
2019-07-13 21:51 ` Yann E. MORIN
2019-06-20 10:07 ` [Buildroot] [PATCH v4 15/15] package/gcc: enable gcc 9.1 for ork1 (openrisc) Giulio Benetti
2019-07-13 21:24 ` Arnout Vandecappelle
2019-07-13 23:57 ` Guo Ren
2019-07-14 8:40 ` Yann E. MORIN
2019-07-14 9:18 ` Guo Ren
2019-07-14 9:39 ` Yann E. MORIN
2019-07-14 10:00 ` Thomas Petazzoni
2019-07-14 10:08 ` Yann E. MORIN
2019-07-14 12:48 ` Romain Naour
2019-07-15 21:55 ` [Buildroot] [arc-buildroot] " Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190713213311.GG2680@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox