From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Makefile: don't export GZIP environment variable
Date: Sun, 14 Jul 2019 20:07:34 +0200 [thread overview]
Message-ID: <20190714180734.GE29941@scaer> (raw)
In-Reply-To: <20190703163959.23070-1-itsatharva@gmail.com>
Atharva, All,
On 2019-07-03 22:09 +0530, Atharva Lele spake thusly:
> We export GZIP = -n so that GZIP does not record original
> name and timestamps. However..
>
> GZIP environment variable is deprecated and soon will not be
> supported in future GZIP versions. GZIP suggests the use of a
> wrapper to pass options globally but it might be difficult to
> implement in Buildroot. For now, we don't export the variable
> and fix reproducibility issues per package as they show up in
> Autobuilder.
This patch must be applied after all caller of gzip have been converted
to use -n.
So far, we identified only fs/comon.mk that calls gzip without -n, and
this is fixed in the following patch.
So, provided the order of these two patches are inversed when applying:
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> Signed-off-by: Atharva Lele <itsatharva@gmail.com>
> ---
> Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c98a0ed87e..9cce934990 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -248,7 +248,6 @@ ifeq ($(BR2_REPRODUCIBLE),y)
> export TZ = UTC
> export LANG = C
> export LC_ALL = C
> -export GZIP = -n
> endif
>
> # To put more focus on warnings, be less verbose as default
> --
> 2.22.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2019-07-14 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 16:39 [Buildroot] [PATCH 1/2] Makefile: don't export GZIP environment variable Atharva Lele
2019-07-03 16:39 ` [Buildroot] [PATCH 2/2] fs/common.mk: do not store original names and timestamps when creating GZIP rootfs Atharva Lele
2019-07-14 18:06 ` Yann E. MORIN
2019-07-14 18:07 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714180734.GE29941@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox