From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] fs/cpio: make cpio rootfs reproducible
Date: Wed, 17 Jul 2019 08:56:22 +0200 [thread overview]
Message-ID: <20190717085622.6c1c6e58@windsurf> (raw)
In-Reply-To: <20190716173518.11081-2-itsatharva@gmail.com>
Hello,
On Tue, 16 Jul 2019 23:05:18 +0530
Atharva Lele <itsatharva@gmail.com> wrote:
> +# --repoducible option was not introduced until cpio v2.12. Some distros
The kind of double negation here "was not introduced until" looked a
bit complicated compared to just "--reproducible was introduced in cpio
v2.12". I've simplified the paragraph to:
+# --repoducible option was introduced in cpio v2.12, which may not be
+# available in some old distributions, so we build host-cpio
And of course now I notice that --repoducible has a typo, and should be
--reproducible. Oh well.
> +# like Ubuntu 16.04 or Debian oldstable which package v2.11. Hence build
> +# host-cpio.
> +ifeq ($(BR2_REPRODUCIBLE), y)
No space after comma. I fixed that up.
Applied with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-07-17 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 17:35 [Buildroot] [PATCH v2 1/2] package/cpio: add host version Atharva Lele
2019-07-16 17:35 ` [Buildroot] [PATCH v2 2/2] fs/cpio: make cpio rootfs reproducible Atharva Lele
2019-07-17 6:56 ` Thomas Petazzoni [this message]
2019-07-17 6:54 ` [Buildroot] [PATCH v2 1/2] package/cpio: add host version Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717085622.6c1c6e58@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox