From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 24 Jul 2019 09:17:55 +0200 Subject: [Buildroot] [PATCH 1/1] utils/test-pkg: add option to enable NLS support In-Reply-To: References: <20190723172336.24010-1-vadim4j@gmail.com> <20190724001359.0a290cf1@windsurf> Message-ID: <20190724091755.534a0136@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Wed, 24 Jul 2019 10:03:24 +0300 Vadim Kochan wrote: > > So I think we should instead ensure that test-pkg by default tests the > > different combinations that we think are useful to test. > > > > OK, I see, I can only say that usually I use test-pkg for version > bumping or checking > the package compilation issue reported in 'Buildroot results' mailing > if it pass, for *.mk changing and of course > for the new packages. So I was thinking that others also use it in > such way, and my > assumption was that --with-nls option would be useful :) Yes, others also use it for the same reason. What I meant is only that others will most likely not remember they should test with and without the --with-nls option. So we should test both NLS enabled and NLS disabled configurations in the default test-pkg run perhaps. But of course then, should we test sysvinit/systemd configurations, to make sure the init script installation logic works ? Should we test hardening options ? etc. We can't test everything in test-pkg as it would make the test too long, and making the test too long will reduce the incentive to use this tool. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com